fix(config): address autoreview findings on JSON5 docs and tests

Erick Kinnee · Erick Kinnee · commit 18137223b436 · 2026-07-17T00:58:52.000Z
- Remove numeric separator claim (not valid JSON5)
- Remove 'None known' unsupported-syntax claim, document known limitations
- Restructure scalar tests to exercise skipVal (resolve sibling after exotic value)
- Remove numeric separator test
diff --git a/src/config/issue-location.test.ts b/src/config/issue-location.test.ts
@@ -105,23 +105,23 @@ describe("resolveConfigIssueLineInRaw", () => {
   });
 
   it("handles hex numbers as values", () => {
-    const raw = ["{", '  "a": 0x1A', "}"].join("\n");
-    expect(resolveConfigIssueLineInRaw(raw, ["a"])).toBe(2);
+    const raw = ["{", '  "a": 0x1A,', '  "b": 1', "}"].join("\n");
+    expect(resolveConfigIssueLineInRaw(raw, ["b"])).toBe(3);
   });
 
   it("handles leading decimal numbers", () => {
-    const raw = ["{", '  "a": .5', "}"].join("\n");
-    expect(resolveConfigIssueLineInRaw(raw, ["a"])).toBe(2);
+    const raw = ["{", '  "a": .5,', '  "b": 1', "}"].join("\n");
+    expect(resolveConfigIssueLineInRaw(raw, ["b"])).toBe(3);
   });
 
   it("handles Infinity value", () => {
-    const raw = ["{", '  "a": Infinity', "}"].join("\n");
-    expect(resolveConfigIssueLineInRaw(raw, ["a"])).toBe(2);
+    const raw = ["{", '  "a": Infinity,', '  "b": 1', "}"].join("\n");
+    expect(resolveConfigIssueLineInRaw(raw, ["b"])).toBe(3);
   });
 
   it("handles NaN value", () => {
-    const raw = ["{", '  "a": NaN', "}"].join("\n");
-    expect(resolveConfigIssueLineInRaw(raw, ["a"])).toBe(2);
+    const raw = ["{", '  "a": NaN,', '  "b": 1', "}"].join("\n");
+    expect(resolveConfigIssueLineInRaw(raw, ["b"])).toBe(3);
   });
 
   it("handles null and boolean values", () => {
@@ -147,13 +147,13 @@ describe("resolveConfigIssueLineInRaw", () => {
   });
 
   it("handles unicode escape sequences in strings", () => {
-    const raw = ["{", '  "a": "hello \\u0041"', "}"].join("\n");
-    expect(resolveConfigIssueLineInRaw(raw, ["a"])).toBe(2);
+    const raw = ["{", '  "a": "hello \\u0041",', '  "b": 1', "}"].join("\n");
+    expect(resolveConfigIssueLineInRaw(raw, ["b"])).toBe(3);
   });
 
   it("handles multi-line string continuation", () => {
-    const raw = ["{", '  "a": "hello \\', 'world"', "}"].join("\n");
-    expect(resolveConfigIssueLineInRaw(raw, ["a"])).toBe(2);
+    const raw = ["{", '  "a": "hello \\', 'world",', '  "b": 1', "}"].join("\n");
+    expect(resolveConfigIssueLineInRaw(raw, ["b"])).toBe(4);
   });
 
   it("handles unicode keys", () => {
@@ -162,13 +162,8 @@ describe("resolveConfigIssueLineInRaw", () => {
   });
 
   it("handles escaped quotes in strings", () => {
-    const raw = ["{", '  "a": "hello \\"world\\""', "}"].join("\n");
-    expect(resolveConfigIssueLineInRaw(raw, ["a"])).toBe(2);
-  });
-
-  it("handles numeric separators in values", () => {
-    const raw = ["{", '  "a": 1_000', "}"].join("\n");
-    expect(resolveConfigIssueLineInRaw(raw, ["a"])).toBe(2);
+    const raw = ["{", '  "a": "hello \\"world\\"",', '  "b": 1', "}"].join("\n");
+    expect(resolveConfigIssueLineInRaw(raw, ["b"])).toBe(3);
   });
 
   it("handles block comments before keys", () => {
diff --git a/src/config/issue-location.ts b/src/config/issue-location.ts
@@ -6,22 +6,22 @@
 // - Arrays: [value, ...] with bracket notation
 // - Strings: double-quoted and single-quoted, with \n, \t, \", \', \\, \uXXXX,
 //   \xXX escape sequences, and multi-line (backslash-newline continuation)
-// - Numbers: integers, floats, hex (0x), leading decimal (.5), Infinity, NaN,
-//   numeric separators (1_000)
+// - Numbers: integers, floats, hex (0x), leading decimal (.5), Infinity, NaN
 // - Comments: // line and /* block */
 // - Trailing commas in objects and arrays
 // - null, true, false literals
 //
 // The navigator only needs to find the byte offset of a value at a given path.
 // It does NOT need to fully parse every value — it skips over values using
 // skipVal/skipComposite. This means value-level syntax (hex numbers, special
-// values, numeric separators) is handled naturally by the value skipper.
+// values) is handled naturally by the value skipper.
 //
-// Unsupported syntax that would cause the navigator to fail gracefully
-// (returns undefined, no crash):
-// - None known — the navigator handles all JSON5 syntax that can appear in
-//   OpenClaw config files. If a path cannot be resolved, the issue degrades
-//   gracefully (no line number, no received value hint).
+// Known limitations (navigator fails gracefully, returns undefined):
+// - Unquoted keys with non-ASCII characters (Unicode letters outside A-Z, a-z,
+//   _, $). Quoted Unicode keys ("café") work fine.
+// - The navigator's scalar skipper is permissive and may skip past text that
+//   the canonical JSON5 parser would reject. This is safe because the navigator
+//   only runs on configs that have already been successfully parsed.
 import path from "node:path";
 import { isSensitiveConfigPath } from "./sensitive-paths.js";
 import type { ConfigValidationIssue } from "./types.js";
