fix(gateway): profiles CI conformance — bindings, lint, knip, sql boundary

steipete · steipete · commit 1807de5d266c · 2026-07-18T22:52:54.000-07:00
diff --git a/apps/android/app/src/main/java/ai/openclaw/app/gateway/GatewayProtocol.kt b/apps/android/app/src/main/java/ai/openclaw/app/gateway/GatewayProtocol.kt
@@ -238,6 +238,10 @@ enum class GatewayMethod(
   BoardEvent("board.event"),
   AuditList("audit.list"),
   AuditActivityList("audit.activity.list"),
+  UsersList("users.list"),
+  UsersLinkEmail("users.linkEmail"),
+  UsersSetDisplayName("users.setDisplayName"),
+  UsersSetAvatar("users.setAvatar"),
   TasksList("tasks.list"),
   TasksGet("tasks.get"),
   TasksCancel("tasks.cancel"),
diff --git a/src/gateway/user-profiles-http.test.ts b/src/gateway/user-profiles-http.test.ts
@@ -16,11 +16,14 @@ vi.mock("../state/user-profiles.js", () => ({
 }));
 
 function response() {
+  const end = vi.fn();
+  const setHeader = vi.fn();
+  const writeHead = vi.fn();
   return {
-    end: vi.fn(),
-    setHeader: vi.fn(),
-    writeHead: vi.fn(),
-  } as unknown as ServerResponse;
+    end,
+    response: { end, setHeader, writeHead } as unknown as ServerResponse,
+    writeHead,
+  };
 }
 
 function request(path: string, headers: Record<string, string> = {}) {
@@ -45,7 +48,7 @@ describe("profile avatar HTTP endpoint", () => {
 
     await handleUserProfileAvatarHttpRequest(
       request("/ignored-by-handler"),
-      res,
+      res.response,
       "/api/users/profile-1/avatar",
       { auth: {} as never },
     );
@@ -71,7 +74,7 @@ describe("profile avatar HTTP endpoint", () => {
 
     await handleUserProfileAvatarHttpRequest(
       request("/ignored-by-handler", { "if-none-match": '"current-hash-png"' }),
-      res,
+      res.response,
       "/api/users/profile-1/avatar",
       { auth: {} as never },
     );
@@ -90,7 +93,7 @@ describe("profile avatar HTTP endpoint", () => {
 
     await handleUserProfileAvatarHttpRequest(
       request("/ignored-by-handler"),
-      response(),
+      response().response,
       "/api/users/profile%2D1/avatar",
       { auth: {} as never },
     );
@@ -109,7 +112,7 @@ describe("profile avatar HTTP endpoint", () => {
 
     await handleUserProfileAvatarHttpRequest(
       { method: "HEAD", url: "/ignored-by-handler", headers: {} } as unknown as IncomingMessage,
-      res,
+      res.response,
       "/api/users/profile-1/avatar",
       { auth: {} as never },
     );
@@ -134,7 +137,7 @@ describe("profile avatar HTTP endpoint", () => {
 
       await handleUserProfileAvatarHttpRequest(
         request("/ignored-by-handler", { "if-none-match": header }),
-        res,
+        res.response,
         "/api/users/profile-1/avatar",
         { auth: {} as never },
       );
diff --git a/src/state/user-profiles.ts b/src/state/user-profiles.ts
@@ -18,11 +18,11 @@ import {
 import { USER_PROFILES_SCHEMA_SQL } from "./user-profiles-schema.js";
 
 export const MAX_USER_PROFILE_AVATAR_BYTES = 512 * 1024;
-export const USER_PROFILE_AVATAR_MIME_TYPES = ["image/png", "image/jpeg", "image/webp"] as const;
+const USER_PROFILE_AVATAR_MIME_TYPES = ["image/png", "image/jpeg", "image/webp"] as const;
 
-export type UserProfileAvatarMime = (typeof USER_PROFILE_AVATAR_MIME_TYPES)[number];
+type UserProfileAvatarMime = (typeof USER_PROFILE_AVATAR_MIME_TYPES)[number];
 
-export type UserProfile = {
+type UserProfile = {
   id: string;
   displayName: string | null;
   avatarMime: UserProfileAvatarMime | null;
@@ -31,19 +31,19 @@ export type UserProfile = {
   updatedAt: number;
 };
 
-export type UserProfileListItem = UserProfile & {
+type UserProfileListItem = UserProfile & {
   emails: string[];
   hasAvatar: boolean;
 };
 
-export type UserProfileAvatar = {
+type UserProfileAvatar = {
   bytes: Uint8Array;
   mime: UserProfileAvatarMime;
   sha256: string;
   updatedAt: number;
 };
 
-export type UserProfileAvatarError =
+type UserProfileAvatarError =
   | { code: "avatar_too_large"; maxBytes: number }
   | { code: "unsupported_avatar_mime"; mime: string };
 
@@ -81,7 +81,7 @@ type UserProfileListRow = Pick<
   UserProfileRow,
   "id" | "display_name" | "avatar_mime" | "merged_into" | "created_at" | "updated_at"
 > & {
-  has_avatar: number;
+  has_avatar: unknown;
 };
 
 const ensuredDatabases = new WeakSet<DatabaseSync>();
@@ -146,6 +146,10 @@ function toUserProfileListItem(row: UserProfileListRow, emails: string[]): UserP
   };
 }
 
+function hasAvatarColumn() {
+  return sql`CASE WHEN avatar IS NULL THEN 0 ELSE 1 END`.as("has_avatar");
+}
+
 function selectUserProfileListItemById(db: DatabaseSync, profileId: string): UserProfileListItem {
   const kysely = profileDb(db);
   const profile = executeSqliteQueryTakeFirstSync(
@@ -159,7 +163,7 @@ function selectUserProfileListItemById(db: DatabaseSync, profileId: string): Use
         "merged_into",
         "created_at",
         "updated_at",
-        sql<number>`CASE WHEN avatar IS NULL THEN 0 ELSE 1 END`.as("has_avatar"),
+        hasAvatarColumn(),
       ])
       .where("id", "=", profileId),
   );
@@ -461,7 +465,7 @@ export function listProfiles(options: OpenClawStateDatabaseOptions = {}): UserPr
             "merged_into",
             "created_at",
             "updated_at",
-            sql<number>`CASE WHEN avatar IS NULL THEN 0 ELSE 1 END`.as("has_avatar"),
+            hasAvatarColumn(),
           ])
           .orderBy("created_at", "asc")
           .orderBy("id", "asc"),
