fix(agents): allow default loopback service endpoints

vincentkoc · vincentkoc · commit 1667654caa44 · 2026-07-11T16:22:22.000+08:00
diff --git a/src/agents/provider-local-service.test.ts b/src/agents/provider-local-service.test.ts
@@ -153,6 +153,39 @@ describe("provider local service", () => {
     await waitForProbeFailure(healthUrl);
   });
 
+  it("allows a default loopback endpoint when provider baseUrl is omitted", async () => {
+    const port = await freePort();
+    const healthUrl = `http://127.0.0.1:${port}/v1/models`;
+    const acquire = createConfiguredProviderLocalServiceAcquirer(() => ({
+      models: {
+        providers: {
+          "gpu-default": {
+            models: [],
+            localService: {
+              command: process.execPath,
+              args: [
+                "-e",
+                `const http=require("http");http.createServer((req,res)=>{res.writeHead(200);res.end("ok");}).listen(${port},"127.0.0.1");`,
+              ],
+              healthUrl,
+              readyTimeoutMs: 5_000,
+              idleStopMs: 1,
+            },
+          },
+        },
+      },
+    }));
+
+    const lease = await acquire({
+      providerId: "gpu-default",
+      baseUrl: `http://127.0.0.1:${port}/v1`,
+    });
+
+    expect(lease).toBeDefined();
+    lease?.release();
+    await waitForProbeFailure(healthUrl);
+  });
+
   it("rejects plugin-selected local service probe hosts", async () => {
     const acquire = createConfiguredProviderLocalServiceAcquirer(() => ({
       models: {
@@ -177,6 +210,29 @@ describe("provider local service", () => {
     ).rejects.toThrow("must match models.providers.gpu-spark.baseUrl");
   });
 
+  it("rejects a remote endpoint when provider baseUrl is omitted", async () => {
+    const acquire = createConfiguredProviderLocalServiceAcquirer(() => ({
+      models: {
+        providers: {
+          "gpu-default": {
+            models: [],
+            localService: {
+              command: process.execPath,
+              args: ["--version"],
+            },
+          },
+        },
+      },
+    }));
+
+    await expect(
+      acquire({
+        providerId: "gpu-default",
+        baseUrl: "http://memory.example/v1",
+      }),
+    ).rejects.toThrow("must match models.providers.gpu-default.baseUrl");
+  });
+
   it("caps oversized local service idle stop timers", async () => {
     const setTimeoutSpy = vi.spyOn(globalThis, "setTimeout");
     const port = await freePort();
diff --git a/src/agents/provider-local-service.ts b/src/agents/provider-local-service.ts
@@ -135,11 +135,24 @@ function configuredProviderBaseUrlVariants(value: string): Set<string> {
   return new Set([normalized, withoutOpenAiPath, `${withoutOpenAiPath}/v1`]);
 }
 
+function isLoopbackProviderBaseUrl(value: string): boolean {
+  const normalized = normalizeProviderBaseUrl(value);
+  if (!normalized) {
+    return false;
+  }
+  const hostname = new URL(normalized).hostname.toLowerCase();
+  return hostname === "localhost" || hostname === "127.0.0.1" || hostname === "[::1]";
+}
+
 function isConfiguredProviderBaseUrl(targetBaseUrl: string, configuredBaseUrl?: string): boolean {
   const target = normalizeProviderBaseUrl(targetBaseUrl);
-  return Boolean(
-    target && configuredBaseUrl && configuredProviderBaseUrlVariants(configuredBaseUrl).has(target),
-  );
+  if (!target) {
+    return false;
+  }
+  const configured = configuredBaseUrl?.trim();
+  return configured
+    ? configuredProviderBaseUrlVariants(configured).has(target)
+    : isLoopbackProviderBaseUrl(target);
 }
 
 /** Attach local-service startup metadata to a model without mutating the original object. */
