test(github-copilot): cover live xhigh reasoning for non-Claude models

saju01 · saju01 · commit 0d0bb4527eab · 2026-06-19T20:49:29.000+02:00
Regression coverage for #59416: when live /models metadata wins over the static xhigh allowlist, non-Claude mini-family ids (e.g. gpt-5.4-mini) must gain xhigh from their resolved compat, while ids whose live effort list lacks xhigh (e.g. gpt-5-mini) must not over-grant it. The live-first model catalog union and models-defaults removal are already in origin/main (75405f6, 46c42d4, d227959); this PR now contributes only the still-missing regression tests on top of that base.
diff --git a/extensions/github-copilot/index.test.ts b/extensions/github-copilot/index.test.ts
@@ -273,6 +273,37 @@ describe("github-copilot plugin", () => {
     expect(profile?.levels.map((level) => level.id)).not.toContain("max");
   });
 
+  it("exposes xhigh thinking for non-Claude Copilot models with catalog xhigh effort", () => {
+    // Regression for #59416: mini-family models (e.g. gpt-5.4-mini) are
+    // entitled to xhigh per live /models, but the static xhigh allowlist only
+    // contains gpt-5.4 and gpt-5.3-codex. When live metadata wins, the
+    // resolved compat must drive xhigh for these non-Claude ids as well.
+    const provider = registerProviderWithPluginConfig({});
+
+    const profile = provider.resolveThinkingProfile({
+      provider: "github-copilot",
+      modelId: "gpt-5.4-mini",
+      compat: { supportedReasoningEfforts: ["none", "low", "medium", "high", "xhigh"] },
+    });
+
+    expect(profile?.levels.map((level) => level.id)).toContain("xhigh");
+  });
+
+  it("omits xhigh for non-Claude Copilot models whose catalog effort lacks it", () => {
+    // Negative half of the #59416 regression: live-first must not over-grant.
+    // gpt-5-mini reports only [low, medium, high] live, so xhigh must stay off
+    // even though the reporter asked for the whole mini family to gain it.
+    const provider = registerProviderWithPluginConfig({});
+
+    const profile = provider.resolveThinkingProfile({
+      provider: "github-copilot",
+      modelId: "gpt-5-mini",
+      compat: { supportedReasoningEfforts: ["low", "medium", "high"] },
+    });
+
+    expect(profile?.levels.map((level) => level.id)).not.toContain("xhigh");
+  });
+
   it("uses live plugin config to re-enable discovery after startup disable", async () => {
     mocks.resolveCopilotApiToken.mockResolvedValueOnce({
       token: "copilot_api_token",
