Skip to content

Commit 0ce2f98

Browse files
committed
fix(plugins): auto-enable non-bundled installed plugins when allowlist is empty
When plugins.allow is empty (no restrictive allowlist), non-bundled installed plugins like npm-installed Slack should be enabled by default. Previously only bundled plugins whose channel was configured received auto-enablement; non-bundled plugins fell through to implicit disabled, requiring users to manually add them to plugins.allow even when no allowlist restriction was in place. Fixes #91873
1 parent d41a3d2 commit 0ce2f98

1 file changed

Lines changed: 19 additions & 0 deletions

File tree

src/plugins/config-activation-shared.ts

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -260,6 +260,25 @@ export function resolvePluginActivationDecisionShared<TRootConfig>(params: {
260260
cause: "enabled-by-effective-config",
261261
};
262262
}
263+
// FIX #91873: When plugins.allow is empty (no restrictive allowlist),
264+
// non-bundled installed plugins (e.g. npm-installed Slack) should be
265+
// enabled by default — matching the auto-load behavior before 2026.6.5.
266+
// Without this, non-bundled plugins with no explicit entry in config fall
267+
// through to implicit disabled, requiring users to manually add them to
268+
// plugins.allow even though no allowlist restriction is in place.
269+
if (
270+
params.origin !== "bundled" &&
271+
params.origin !== "workspace" &&
272+
params.config.allow.length === 0
273+
) {
274+
return {
275+
enabled: true,
276+
activated: true,
277+
explicitlyEnabled: false,
278+
source: "default",
279+
cause: "non-bundled-auto-enable",
280+
};
281+
}
263282
if (
264283
params.origin === "bundled" &&
265284
params.isBundledChannelEnabledByChannelConfig(params.rootConfig, params.id)

0 commit comments

Comments
 (0)