fix(control-ui): reconcile channel tab refresh replay

BunsDev · BunsDev · commit 0c4ead2373b1 · 2026-05-11T07:08:03.000-05:00
diff --git a/ui/src/ui/app-gateway-chat-load.node.test.ts b/ui/src/ui/app-gateway-chat-load.node.test.ts
@@ -219,12 +219,12 @@ describe("connectGateway chat load startup work", () => {
     expect(refreshChatAvatarMock).toHaveBeenCalledWith(host);
   });
 
-  it("lets the active tab refresh own node and device loading after hello", () => {
+  it("lets the active tab refresh own node and device loading after hello", async () => {
     const { host, client } = connectHost("overview");
 
     client.emitHello();
 
-    expect(refreshActiveTabMock).toHaveBeenCalledWith(host);
+    await vi.waitFor(() => expect(refreshActiveTabMock).toHaveBeenCalledWith(host));
     expect(loadNodesMock).not.toHaveBeenCalled();
     expect(loadDevicesMock).not.toHaveBeenCalled();
   });
diff --git a/ui/src/ui/app-settings.refresh-active-tab.node.test.ts b/ui/src/ui/app-settings.refresh-active-tab.node.test.ts
@@ -353,31 +353,24 @@ describe("refreshActiveTab", () => {
     });
   });
 
-  it("renders channels from the cheap snapshot before starting slow probes", async () => {
+  it("renders channels from the cheap snapshot without waiting for config schema", async () => {
     const host = createHost();
     host.tab = "channels";
     const schema = createDeferred();
-    const channelProbe = createDeferred();
     mocks.loadConfigSchemaMock.mockReturnValueOnce(schema.promise);
-    mocks.loadChannelsMock.mockImplementation(async (_host, probe) => {
-      if (probe) {
-        await channelProbe.promise;
-      }
-    });
 
     const refresh = refreshActiveTab(host as never);
     const outcome = await raceWithNextMacrotask(refresh);
 
     expect(outcome).toBe("resolved");
-    expect(mocks.loadChannelsMock.mock.calls.map(([, probe]) => probe)).toEqual([false, true]);
+    expect(mocks.loadChannelsMock.mock.calls.map(([, probe]) => probe)).toEqual([false]);
     expect(mocks.loadConfigMock).toHaveBeenCalledOnce();
     expect(host.requestUpdate).not.toHaveBeenCalled();
 
     schema.resolve();
-    channelProbe.resolve();
 
     await vi.waitFor(() => {
-      expect(host.requestUpdate).toHaveBeenCalledTimes(2);
+      expect(host.requestUpdate).toHaveBeenCalledOnce();
     });
   });
 
diff --git a/ui/src/ui/app-settings.ts b/ui/src/ui/app-settings.ts
@@ -852,7 +852,8 @@ function buildAttentionItems(host: SettingsAppHost) {
 
 export async function loadChannelsTab(host: SettingsHost) {
   const app = host as unknown as SettingsAppHost;
-  await Promise.all([loadChannels(app, false), loadConfigSchema(app), loadConfig(app)]);
+  void loadConfigSchema(app).finally(() => host.requestUpdate?.());
+  await Promise.all([loadChannels(app, false), loadConfig(app)]);
 }
 
 export async function loadCron(host: SettingsHost) {

Original file line number	Diff line number	Diff line change
`@@ -852,7 +852,8 @@ function buildAttentionItems(host: SettingsAppHost) {`
`852`	`852`
`853`	`853`	`export async function loadChannelsTab(host: SettingsHost) {`
`854`	`854`	`const app = host as unknown as SettingsAppHost;`
`855`		`- await Promise.all([loadChannels(app, false), loadConfigSchema(app), loadConfig(app)]);`
	`855`	`+ void loadConfigSchema(app).finally(() => host.requestUpdate?.());`
	`856`	`+ await Promise.all([loadChannels(app, false), loadConfig(app)]);`
`856`	`857`	`}`
`857`	`858`
`858`	`859`	`export async function loadCron(host: SettingsHost) {`