test(plugin-sdk): isolate runtime facade tests

vincentkoc · vincentkoc · commit 061a3705dbe2 · 2026-06-19T20:55:49.000+02:00
diff --git a/src/plugin-sdk/anthropic-vertex-auth-presence.preflight.test.ts b/src/plugin-sdk/anthropic-vertex-auth-presence.preflight.test.ts
@@ -1,7 +1,7 @@
 /**
  * Preflight tests for Anthropic Vertex auth presence helpers.
  */
-import { afterEach, describe, expect, it, vi } from "vitest";
+import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
 
 const { existsSyncMock, readFileSyncMock } = vi.hoisted(() => ({
   existsSyncMock: vi.fn(),
@@ -28,17 +28,20 @@ vi.mock("node:fs", async () => {
   };
 });
 
-import { hasAnthropicVertexAvailableAuth } from "./anthropic-vertex-auth-presence.js";
-
 describe("hasAnthropicVertexAvailableAuth ADC preflight", () => {
+  beforeEach(() => {
+    vi.resetModules();
+  });
+
   afterEach(() => {
     existsSyncMock.mockClear();
     readFileSyncMock.mockClear();
   });
 
-  it("reads explicit ADC credentials without an existsSync preflight", () => {
+  it("reads explicit ADC credentials without an existsSync preflight", async () => {
     existsSyncMock.mockClear();
     readFileSyncMock.mockClear();
+    const { hasAnthropicVertexAvailableAuth } = await import("./anthropic-vertex-auth-presence.js");
 
     expect(
       hasAnthropicVertexAvailableAuth({
diff --git a/src/plugin-sdk/browser-bridge.test.ts b/src/plugin-sdk/browser-bridge.test.ts
@@ -10,6 +10,7 @@ vi.mock("./facade-runtime.js", () => ({
 
 describe("browser bridge facade", () => {
   beforeEach(() => {
+    vi.resetModules();
     loadActivatedBundledPluginPublicSurfaceModuleSync.mockReset();
   });
 
diff --git a/src/plugin-sdk/qa-runner-runtime.test.ts b/src/plugin-sdk/qa-runner-runtime.test.ts
@@ -50,8 +50,10 @@ function firstPublicSurfaceCall(): PublicSurfaceCall | undefined {
 describe("plugin-sdk qa-runner-runtime", () => {
   const tempDirs: string[] = [];
   const originalPrivateQaCli = process.env.OPENCLAW_ENABLE_PRIVATE_QA_CLI;
+  const originalBundledPluginsDir = process.env.OPENCLAW_BUNDLED_PLUGINS_DIR;
 
   beforeEach(() => {
+    vi.resetModules();
     loadPluginManifestRegistry.mockReset().mockReturnValue({
       plugins: [],
       diagnostics: [],
@@ -60,11 +62,17 @@ describe("plugin-sdk qa-runner-runtime", () => {
     tryLoadActivatedBundledPluginPublicSurfaceModuleSync.mockReset();
     resolveOpenClawPackageRootSync.mockReset().mockReturnValue(null);
     delete process.env.OPENCLAW_ENABLE_PRIVATE_QA_CLI;
+    delete process.env.OPENCLAW_BUNDLED_PLUGINS_DIR;
   });
 
   afterEach(() => {
     cleanupTempDirs(tempDirs);
     restorePrivateQaCliEnv(originalPrivateQaCli);
+    if (originalBundledPluginsDir === undefined) {
+      delete process.env.OPENCLAW_BUNDLED_PLUGINS_DIR;
+    } else {
+      process.env.OPENCLAW_BUNDLED_PLUGINS_DIR = originalBundledPluginsDir;
+    }
   });
 
   it("stays cold until runner discovery is requested", async () => {
diff --git a/src/plugin-sdk/qa-runtime.test.ts b/src/plugin-sdk/qa-runtime.test.ts
@@ -25,16 +25,24 @@ vi.mock("../infra/openclaw-root.js", () => ({
 describe("plugin-sdk qa-runtime", () => {
   const tempDirs: string[] = [];
   const originalPrivateQaCli = process.env.OPENCLAW_ENABLE_PRIVATE_QA_CLI;
+  const originalBundledPluginsDir = process.env.OPENCLAW_BUNDLED_PLUGINS_DIR;
 
   beforeEach(() => {
+    vi.resetModules();
     loadBundledPluginPublicSurfaceModuleSync.mockReset();
     resolveOpenClawPackageRootSync.mockReset().mockReturnValue(null);
     delete process.env.OPENCLAW_ENABLE_PRIVATE_QA_CLI;
+    delete process.env.OPENCLAW_BUNDLED_PLUGINS_DIR;
   });
 
   afterEach(() => {
     cleanupTempDirs(tempDirs);
     restorePrivateQaCliEnv(originalPrivateQaCli);
+    if (originalBundledPluginsDir === undefined) {
+      delete process.env.OPENCLAW_BUNDLED_PLUGINS_DIR;
+    } else {
+      process.env.OPENCLAW_BUNDLED_PLUGINS_DIR = originalBundledPluginsDir;
+    }
   });
 
   async function occupyLoopbackPort(): Promise<{ close: () => Promise<void>; port: number }> {
