fix(ui): make ui build work on Windows

xiwuqi · xiwuqi · commit 05a293af2494 · 2026-03-22T09:36:00.000-05:00
diff --git a/scripts/ui.js b/scripts/ui.js
@@ -61,6 +61,16 @@ export function shouldUseShellForCommand(cmd, platform = process.platform) {
   return WINDOWS_SHELL_EXTENSIONS.has(extension);
 }
 
+export function quoteWindowsShellCommand(cmd, platform = process.platform) {
+  if (!shouldUseShellForCommand(cmd, platform) || !/\s/.test(cmd)) {
+    return cmd;
+  }
+  if (cmd.startsWith('"') && cmd.endsWith('"')) {
+    return cmd;
+  }
+  return `"${cmd}"`;
+}
+
 export function assertSafeWindowsShellArgs(args, platform = process.platform) {
   if (platform !== "win32") {
     return;
@@ -91,8 +101,9 @@ function createSpawnOptions(cmd, args, envOverride) {
 
 function run(cmd, args) {
   let child;
+  const actualCmd = quoteWindowsShellCommand(cmd);
   try {
-    child = spawn(cmd, args, createSpawnOptions(cmd, args));
+    child = spawn(actualCmd, args, createSpawnOptions(cmd, args));
   } catch (err) {
     console.error(`Failed to launch ${cmd}:`, err);
     process.exit(1);
@@ -112,8 +123,9 @@ function run(cmd, args) {
 
 function runSync(cmd, args, envOverride) {
   let result;
+  const actualCmd = quoteWindowsShellCommand(cmd);
   try {
-    result = spawnSync(cmd, args, createSpawnOptions(cmd, args, envOverride));
+    result = spawnSync(actualCmd, args, createSpawnOptions(cmd, args, envOverride));
   } catch (err) {
     console.error(`Failed to launch ${cmd}:`, err);
     process.exit(1);
@@ -184,10 +196,7 @@ export function main(argv = process.argv.slice(2)) {
   }
 
   if (!depsInstalled(action === "test" ? "test" : "build")) {
-    const installEnv =
-      action === "build" ? { ...process.env, NODE_ENV: "production" } : process.env;
-    const installArgs = action === "build" ? ["install", "--prod"] : ["install"];
-    runSync(runner.cmd, installArgs, installEnv);
+    runSync(runner.cmd, ["install"]);
   }
 
   run(runner.cmd, ["run", script, ...rest]);
diff --git a/test/scripts/ui.test.ts b/test/scripts/ui.test.ts
@@ -1,5 +1,9 @@
 import { describe, expect, it } from "vitest";
-import { assertSafeWindowsShellArgs, shouldUseShellForCommand } from "../../scripts/ui.js";
+import {
+  assertSafeWindowsShellArgs,
+  quoteWindowsShellCommand,
+  shouldUseShellForCommand,
+} from "../../scripts/ui.js";
 
 describe("scripts/ui windows spawn behavior", () => {
   it("enables shell for Windows command launchers that require cmd.exe", () => {
@@ -14,6 +18,16 @@ describe("scripts/ui windows spawn behavior", () => {
     expect(shouldUseShellForCommand("/usr/local/bin/pnpm", "linux")).toBe(false);
   });
 
+  it("quotes Windows shell launcher paths that contain spaces", () => {
+    expect(quoteWindowsShellCommand("C:\\Program Files\\pnpm\\pnpm.cmd", "win32")).toBe(
+      '"C:\\Program Files\\pnpm\\pnpm.cmd"',
+    );
+    expect(quoteWindowsShellCommand("C:\\tools\\pnpm.cmd", "win32")).toBe("C:\\tools\\pnpm.cmd");
+    expect(quoteWindowsShellCommand("C:\\Program Files\\nodejs\\node.exe", "win32")).toBe(
+      "C:\\Program Files\\nodejs\\node.exe",
+    );
+  });
+
   it("allows safe forwarded args when shell mode is required on Windows", () => {
     expect(() =>
       assertSafeWindowsShellArgs(["run", "build", "--filter", "@openclaw/ui"], "win32"),
