Skip to content

Commit 04240e6

Browse files
committed
fix: add bindings comment regression test (#23458) (thanks @echoVic)
1 parent 9240432 commit 04240e6

File tree

2 files changed

+11
-0
lines changed

2 files changed

+11
-0
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -93,6 +93,7 @@ Docs: https://docs.openclaw.ai
9393
- Cron: persist `delivered` state in cron job records so delivery failures remain visible in status and logs. (#19174) Thanks @simonemacario.
9494
- Config/Doctor: only repair the OAuth credentials directory when affected channels are configured, avoiding fresh-install noise.
9595
- Config/Channels: whitelist `channels.modelByChannel` in config validation and exclude it from plugin auto-enable channel detection so model overrides no longer trigger `unknown channel id` validation errors or bogus `modelByChannel` plugin enables. (#23412) Thanks @ProspectOre.
96+
- Config/Bindings: allow optional `bindings[].comment` in strict config validation so annotated binding entries no longer fail load. (#23458) Thanks @echoVic.
9697
- Usage/Pricing: correct MiniMax M2.5 pricing defaults to fix inflated cost reporting. (#22755) Thanks @miloudbelarebia.
9798
- Gateway/Daemon: verify gateway health after daemon restart.
9899
- Agents/UI text: stop rewriting normal assistant billing/payment language outside explicit error contexts. (#17834) Thanks @niceysam.

src/config/config.legacy-config-detection.accepts-imessage-dmpolicy.e2e.test.ts

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -363,6 +363,16 @@ describe("legacy config detection", () => {
363363
expectedValue: "work",
364364
});
365365
});
366+
it("accepts bindings[].comment on load", () => {
367+
expectValidConfigValue({
368+
config: {
369+
bindings: [{ agentId: "main", comment: "primary route", match: { channel: "telegram" } }],
370+
},
371+
readValue: (config) =>
372+
(config as { bindings?: Array<{ comment?: string }> }).bindings?.[0]?.comment,
373+
expectedValue: "primary route",
374+
});
375+
});
366376
it("rejects session.sendPolicy.rules[].match.provider on load", async () => {
367377
await withTempHome(async (home) => {
368378
const configPath = path.join(home, ".openclaw", "openclaw.json");

0 commit comments

Comments
 (0)