fix(ci): keep unused exports advisory

vincentkoc · vincentkoc · commit 02656354d317 · 2026-07-12T14:39:45.000-07:00
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -1604,18 +1604,9 @@ jobs:
                 ' "$1"
               }
               if has_package_script "deadcode:dependencies" &&
-                has_package_script "deadcode:unused-files" &&
-                has_package_script "deadcode:exports"; then
+                has_package_script "deadcode:unused-files"; then
                 pnpm deadcode:dependencies
                 pnpm deadcode:unused-files
-                pnpm deadcode:exports
-              elif [[ "$HISTORICAL_TARGET" == "true" ]] &&
-                has_package_script "deadcode:dependencies" &&
-                has_package_script "deadcode:unused-files" &&
-                has_package_script "deadcode:report:ci:ts-unused"; then
-                pnpm deadcode:dependencies
-                pnpm deadcode:unused-files
-                pnpm deadcode:report:ci:ts-unused
               elif [[ "$HISTORICAL_TARGET" == "true" ]] && has_package_script "deadcode:ci"; then
                 pnpm deadcode:ci
               else
diff --git a/docs/ci.md b/docs/ci.md
@@ -111,7 +111,7 @@ job budget.
 
 Android CI runs both `testPlayDebugUnitTest` and `testThirdPartyDebugUnitTest` and then builds the Play debug APK. The third-party flavor has no separate source set or manifest; its unit-test lane still compiles the flavor with the SMS/call-log BuildConfig flags, while avoiding a duplicate debug APK packaging job on every Android-relevant push.
 
-The `check-dependencies` shard runs a production Knip dependency-only pass, the unused-file allowlist check, and the enforced unused-exports baseline ratchet. The unused-file guard fails when a PR adds a new unreviewed unused file or leaves a stale allowlist entry, while preserving intentional dynamic plugin, generated, build, live-test, and package bridge surfaces that Knip cannot resolve statically. The unused-exports ratchet likewise rejects new findings and stale required baseline entries, so the checked-in debt can only shrink. The former ts-prune and ts-unused-exports advisory reports no longer run.
+The `check-dependencies` shard runs a production Knip dependency-only pass and the unused-file allowlist check. The unused-file guard fails when a PR adds a new unreviewed unused file or leaves a stale allowlist entry, while preserving intentional dynamic plugin, generated, build, live-test, and package bridge surfaces that Knip cannot resolve statically. The unused-exports baseline remains available as an advisory maintenance scan through `pnpm deadcode:exports`; after deleting dead code, regenerate it with `pnpm deadcode:exports:update`.
 
 ## ClawSweeper activity forwarding
 
diff --git a/test/scripts/ci-workflow-guards.test.ts b/test/scripts/ci-workflow-guards.test.ts
@@ -1746,17 +1746,13 @@ describe("ci workflow guards", () => {
     expect(preflightGuards).toContain("pnpm deps:patches:check");
   });
 
-  it("uses the target-owned deadcode contract for current and frozen checkouts", () => {
+  it("uses stable deadcode checks for current and frozen checkouts", () => {
     const modern = runDependencyCheckFixture({
       historicalTarget: false,
       scripts: ["deadcode:dependencies", "deadcode:unused-files", "deadcode:exports"],
     });
     expect(modern.status, modern.output).toBe(0);
-    expect(modern.calls).toEqual([
-      "deadcode:dependencies",
-      "deadcode:unused-files",
-      "deadcode:exports",
-    ]);
+    expect(modern.calls).toEqual(["deadcode:dependencies", "deadcode:unused-files"]);
 
     const frozen = runDependencyCheckFixture({
       historicalTarget: true,
@@ -1768,15 +1764,18 @@ describe("ci workflow guards", () => {
       ],
     });
     expect(frozen.status, frozen.output).toBe(0);
-    expect(frozen.calls).toEqual([
-      "deadcode:dependencies",
-      "deadcode:unused-files",
-      "deadcode:report:ci:ts-unused",
-    ]);
+    expect(frozen.calls).toEqual(["deadcode:dependencies", "deadcode:unused-files"]);
+
+    const legacy = runDependencyCheckFixture({
+      historicalTarget: true,
+      scripts: ["deadcode:ci"],
+    });
+    expect(legacy.status, legacy.output).toBe(0);
+    expect(legacy.calls).toEqual(["deadcode:ci"]);
 
     const incompleteCurrent = runDependencyCheckFixture({
       historicalTarget: false,
-      scripts: ["deadcode:dependencies", "deadcode:unused-files"],
+      scripts: ["deadcode:dependencies"],
     });
     expect(incompleteCurrent.status).toBe(1);
     expect(incompleteCurrent.calls).toEqual([]);
@@ -2066,8 +2065,9 @@ describe("ci workflow guards", () => {
     );
     expect(checkShard.run).toContain("pnpm tsgo:scripts");
     expect(checkShard.run).toContain('elif [[ "$HISTORICAL_TARGET" != "true" ]]');
-    expect(checkShard.run).toContain('has_package_script "deadcode:exports"');
-    expect(checkShard.run).toContain('has_package_script "deadcode:report:ci:ts-unused"');
+    expect(checkShard.run).toContain('has_package_script "deadcode:dependencies"');
+    expect(checkShard.run).toContain('has_package_script "deadcode:unused-files"');
+    expect(checkShard.run).not.toContain('has_package_script "deadcode:exports"');
     expect(checkShard.run).toContain(
       'elif [[ "$HISTORICAL_TARGET" == "true" ]] && has_package_script "deadcode:ci"',
     );
