Skip to content

Commit 024c90f

Browse files
qingminglongqingminglong
committed
Merge remote-tracking branch 'upstream/main' into codex/fix-log-tail-short-reads
2 parents 0ca736b + 7bb59c4 commit 024c90f

1,148 files changed

Lines changed: 84338 additions & 18088 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎.agents/skills/autoreview/SKILL.md‎

Lines changed: 13 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -204,8 +204,19 @@ Parallel tests inherit only a small allowlist of ordinary OS, CI, and toolchain
204204
variables. Put additional non-secret project controls directly in the test command.
205205
Home and standard config directories point to a temporary isolated root that is
206206
removed after the command exits. Do not put secrets in the command because it is
207-
printed before execution. Run secret-bearing or credentialed tests separately in an
208-
appropriately isolated remote runner.
207+
printed before execution. Set `OPENCLAW_TESTBOX=1` on the autoreview process, not
208+
inside the test command, because the environment snapshot and credential staging
209+
happen before the test shell starts:
210+
211+
```bash
212+
OPENCLAW_TESTBOX=1 "$AUTOREVIEW" --parallel-tests "pnpm check:changed"
213+
```
214+
215+
This is the narrow trusted-maintainer-code exception: it stages only the Blacksmith
216+
credential file into the temporary home so the command can delegate remotely. Never
217+
use this credential-hydrated path for untrusted contributor or fork code. Run other
218+
secret-bearing or credentialed tests separately in an appropriately isolated remote
219+
runner.
209220

210221
Tradeoff: tests may force code changes that stale the review. If tests or review lead to code edits, rerun the affected tests and rerun review until no accepted/actionable findings remain. Once that rerun exits cleanly, stop; do not spend another long review cycle on redundant confirmation.
211222

0 commit comments

Comments
 (0)