fix(heartbeat): tolerate invalid commitment due timestamps

steipete · steipete · commit 023a101b9138 · 2026-05-30T06:41:16.000-04:00
diff --git a/src/infra/heartbeat-runner.commitments.test.ts b/src/infra/heartbeat-runner.commitments.test.ts
@@ -30,6 +30,7 @@ describe("runHeartbeatOnce commitments", () => {
     id: string;
     sessionKey: string;
     to: string;
+    dueWindow?: CommitmentRecord["dueWindow"];
     sourceUserText?: string;
     sourceAssistantText?: string;
   }): CommitmentRecord {
@@ -48,7 +49,7 @@ describe("runHeartbeatOnce commitments", () => {
       suggestedText: "How did the interview go?",
       dedupeKey: "interview:2026-04-28",
       confidence: 0.92,
-      dueWindow: {
+      dueWindow: params.dueWindow ?? {
         earliestMs: nowMs - 60_000,
         latestMs: nowMs + 60 * 60_000,
         timezone: "America/Los_Angeles",
@@ -76,6 +77,7 @@ describe("runHeartbeatOnce commitments", () => {
   async function setupCommitmentCase(params?: {
     replyText?: string;
     target?: "last" | "none";
+    dueWindow?: CommitmentRecord["dueWindow"];
     sourceUserText?: string;
     sourceAssistantText?: string;
     legacyRawSourceText?: boolean;
@@ -111,6 +113,7 @@ describe("runHeartbeatOnce commitments", () => {
             id: "cm_interview",
             sessionKey,
             to: "155462274",
+            dueWindow: params?.dueWindow,
             sourceUserText: params?.sourceUserText,
             sourceAssistantText: params?.sourceAssistantText,
           }),
@@ -391,6 +394,25 @@ describe("runHeartbeatOnce commitments", () => {
     });
   });
 
+  it("tolerates Date-invalid commitment due timestamps in heartbeat prompts", async () => {
+    const { result, sendTelegram, store } = await setupCommitmentCase({
+      dueWindow: {
+        earliestMs: nowMs - 60_000,
+        latestMs: 8_700_000_000_000_000,
+        timezone: "UTC",
+      },
+    });
+
+    expect(result.status).toBe("ran");
+    expect(sendTelegram).toHaveBeenCalled();
+    expectCommitmentFields(store.commitments[0], {
+      id: "cm_interview",
+      status: "sent",
+      attempts: 1,
+      sentAtMs: nowMs,
+    });
+  });
+
   it("dismisses a due commitment when the heartbeat model declines to send a check-in", async () => {
     const { result, sendTelegram, store } = await setupCommitmentCase({
       replyText: HEARTBEAT_TOKEN,
diff --git a/src/infra/heartbeat-runner.ts b/src/infra/heartbeat-runner.ts
@@ -89,6 +89,7 @@ import {
   toAgentStoreSessionKey,
 } from "../routing/session-key.js";
 import { defaultRuntime, type RuntimeEnv } from "../runtime.js";
+import { timestampMsToIsoString } from "../shared/number-coercion.js";
 import {
   normalizeLowercaseStringOrEmpty,
   normalizeOptionalString,
@@ -894,8 +895,8 @@ function buildCommitmentHeartbeatPrompt(params: {
     reason: commitment.reason,
     suggestedText: commitment.suggestedText,
     due: {
-      earliest: new Date(commitment.dueWindow.earliestMs).toISOString(),
-      latest: new Date(commitment.dueWindow.latestMs).toISOString(),
+      earliest: timestampMsToIsoString(commitment.dueWindow.earliestMs) ?? "n/a",
+      latest: timestampMsToIsoString(commitment.dueWindow.latestMs) ?? "n/a",
       timezone: commitment.dueWindow.timezone,
     },
     sourceMessageId: commitment.sourceMessageId,
