[AI] fix(memory-core): use replaceFileAtomic for dreaming writes and narrow catch block (ClawSweeper P1)

SunnyShu0925 · SunnyShu0925 · commit 0214b37c748f · 2026-06-23T21:09:44.000+08:00
- Replace manual tmp-${randomUUID()}+writeFile+rename with replaceFileAtomic from @openclaw/fs-safe for all three dreaming write paths: inline daily (preserveExistingMode), separate report, and deep separate report. Removed unused randomUUID import. - Narrow fs.access catch block in repairShortTermPromotionArtifacts to only suppress ENOENT — EACCES/EPERM now rethrow instead of triggering dangling-ref pruning. - Both fixes address ClawSweeper P1 findings on PR #94537.
diff --git a/extensions/memory-core/src/dreaming-markdown.ts b/extensions/memory-core/src/dreaming-markdown.ts
@@ -1,5 +1,4 @@
 // Memory Core plugin module implements dreaming markdown behavior.
-import { randomUUID } from "node:crypto";
 import fs from "node:fs/promises";
 import path from "node:path";
 import {
@@ -12,6 +11,7 @@ import {
   replaceManagedMarkdownBlock,
   withTrailingNewline,
 } from "openclaw/plugin-sdk/memory-host-markdown";
+import { replaceFileAtomic } from "openclaw/plugin-sdk/security-runtime";
 import { updateDeepDreamsFile } from "./dreaming-dreams-file.js";
 import { resolveMemoryCoreNowMs, resolveMemoryCoreTimestamp } from "./time.js";
 
@@ -91,9 +91,14 @@ export async function writeDailyDreamingPhaseBlock(params: {
     });
     // Write atomically via temp file so a crash mid-write cannot truncate the
     // daily memory file (read-modify-write on a non-atomic filesystem).
-    const inlineTmpPath = `${inlinePath}.tmp-${randomUUID()}`;
-    await fs.writeFile(inlineTmpPath, withTrailingNewline(updated), "utf-8");
-    await fs.rename(inlineTmpPath, inlinePath);
+    await replaceFileAtomic({
+      filePath: inlinePath,
+      content: withTrailingNewline(updated),
+      mode: 0o600,
+      preserveExistingMode: true,
+      tempPrefix: "dreaming-inline",
+      throwOnCleanupError: true,
+    });
   }
 
   if (shouldWriteSeparate(params.storage)) {
@@ -110,9 +115,13 @@ export async function writeDailyDreamingPhaseBlock(params: {
       body,
       "",
     ].join("\n");
-    const reportTmpPath = `${reportPath}.tmp-${randomUUID()}`;
-    await fs.writeFile(reportTmpPath, report, "utf-8");
-    await fs.rename(reportTmpPath, reportPath);
+    await replaceFileAtomic({
+      filePath: reportPath,
+      content: report,
+      mode: 0o600,
+      tempPrefix: "dreaming-report",
+      throwOnCleanupError: true,
+    });
   }
 
   await appendMemoryHostEvent(params.workspaceDir, {
@@ -148,9 +157,13 @@ export async function writeDeepDreamingReport(params: {
   if (shouldWriteSeparate(params.storage)) {
     reportPath = resolveSeparateReportPath(params.workspaceDir, "deep", nowMs, params.timezone);
     await fs.mkdir(path.dirname(reportPath), { recursive: true });
-    const reportTmpPath = `${reportPath}.tmp-${randomUUID()}`;
-    await fs.writeFile(reportTmpPath, `# Deep Sleep\n\n${body}\n`, "utf-8");
-    await fs.rename(reportTmpPath, reportPath);
+    await replaceFileAtomic({
+      filePath: reportPath,
+      content: `# Deep Sleep\n\n${body}\n`,
+      mode: 0o600,
+      tempPrefix: "dreaming-deep",
+      throwOnCleanupError: true,
+    });
   }
   await appendMemoryHostEvent(params.workspaceDir, {
     type: "memory.dream.completed",
diff --git a/extensions/memory-core/src/short-term-promotion.ts b/extensions/memory-core/src/short-term-promotion.ts
@@ -2774,8 +2774,12 @@ export async function repairShortTermPromotionArtifacts(params: {
             await fs.access(sourcePath);
             sourceExists = true;
             break;
-          } catch {
-            // ENOENT or other error — try next candidate path
+          } catch (err) {
+            // Only treat ENOENT (file genuinely doesn't exist) as missing.
+            // EACCES, EPERM, and other errors should not trigger pruning.
+            if ((err as NodeJS.ErrnoException)?.code !== "ENOENT") {
+              throw err;
+            }
           }
         }
         if (!sourceExists) {
