test: migrate leaky raw mkdtemp calls to createSuiteTempRootTracker()

xialonglee · claude · xialonglee · commit 013e12136beb · 2026-06-24T10:39:59.000+08:00
Gap finding: tempdir-8h9i0j1k, tempdir-9i0j1k2l Replace bare fs.mkdtemp/mkdtempSync calls in 4 test files with the shared createSuiteTempRootTracker() helper, adding proper cleanup where none existed. Background: the project has standardized on shared temp dir helpers since 88b87d8 (withTempDir) -> 13df67e (createSuiteTempRootTracker) -> 06431fd / #87298 (CI guard + docs guidance). This PR continues that migration for the highest-risk files. Files changed: - src/skills/lifecycle/install-fallback.test.ts: variable overwrite risk - src/auto-reply/reply/session-hooks-context.test.ts: helper leaks temp dirs - src/auto-reply/reply/abort.test.ts: createAbortConfig leaks root dir - src/auto-reply/inbound.test.ts: test cases without cleanup Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
diff --git a/src/auto-reply/inbound.test.ts b/src/auto-reply/inbound.test.ts
@@ -1,12 +1,11 @@
 /** Tests inbound auto-reply handling across channel message contexts. */
-import fs from "node:fs/promises";
-import os from "node:os";
 import path from "node:path";
-import { beforeEach, describe, expect, it, vi } from "vitest";
+import { afterAll, beforeAll, beforeEach, describe, expect, it, vi } from "vitest";
 import type { OpenClawConfig } from "../config/config.js";
 import type { GroupKeyResolution } from "../config/sessions.js";
 import { channelRouteDedupeKey } from "../plugin-sdk/channel-route.js";
 import { resetPluginRuntimeStateForTest, setActivePluginRegistry } from "../plugins/runtime.js";
+import { createSuiteTempRootTracker } from "../test-helpers/temp-dir.js";
 import { createChannelTestPluginBase, createTestRegistry } from "../test-utils/channel-plugins.js";
 import { createInboundDebouncer } from "./inbound-debounce.js";
 import { resolveGroupRequireMention } from "./reply/groups.js";
@@ -985,9 +984,21 @@ describe("createInboundDebouncer", () => {
   });
 });
 
+const senderMetaTempDirs = createSuiteTempRootTracker({
+  prefix: "openclaw-sender-meta-",
+});
+
 describe("initSessionState BodyStripped", () => {
+  beforeAll(async () => {
+    await senderMetaTempDirs.setup();
+  });
+
+  afterAll(async () => {
+    await senderMetaTempDirs.cleanup();
+  });
+
   it("prefers BodyForAgent over Body for group chats", async () => {
-    const root = await fs.mkdtemp(path.join(os.tmpdir(), "openclaw-sender-meta-"));
+    const root = await senderMetaTempDirs.make("group");
     const storePath = path.join(root, "sessions.json");
     const cfg = { session: { store: storePath } } as OpenClawConfig;
 
@@ -1009,7 +1020,7 @@ describe("initSessionState BodyStripped", () => {
   });
 
   it("prefers BodyForAgent over Body for direct chats", async () => {
-    const root = await fs.mkdtemp(path.join(os.tmpdir(), "openclaw-sender-meta-direct-"));
+    const root = await senderMetaTempDirs.make("direct");
     const storePath = path.join(root, "sessions.json");
     const cfg = { session: { store: storePath } } as OpenClawConfig;
 
diff --git a/src/auto-reply/reply/abort.test.ts b/src/auto-reply/reply/abort.test.ts
@@ -1,10 +1,10 @@
 // Tests abort request handling, cutoff persistence, and active run cleanup.
 import fs from "node:fs/promises";
-import os from "node:os";
 import path from "node:path";
-import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
+import { afterAll, afterEach, beforeAll, beforeEach, describe, expect, it, vi } from "vitest";
 import type { SubagentRunRecord } from "../../agents/subagent-registry.js";
 import type { OpenClawConfig } from "../../config/config.js";
+import { createSuiteTempRootTracker } from "../../test-helpers/temp-dir.js";
 import type { SessionAbortTargetResult } from "../../config/sessions/session-accessor.js";
 import {
   testing as abortTesting,
@@ -83,7 +83,17 @@ vi.mock("../../acp/control-plane/manager.js", () => ({
   }),
 }));
 
+const suiteTempDirs = createSuiteTempRootTracker({ prefix: "openclaw-abort-" });
+
 describe("abort detection", () => {
+  beforeAll(async () => {
+    await suiteTempDirs.setup();
+  });
+
+  afterAll(async () => {
+    await suiteTempDirs.cleanup();
+  });
+
   async function writeSessionStore(
     storePath: string,
     sessionIdsByKey: Record<string, string>,
@@ -103,7 +113,7 @@ describe("abort detection", () => {
     sessionIdsByKey?: Record<string, string>;
     nowMs?: number;
   }) {
-    const root = await fs.mkdtemp(path.join(os.tmpdir(), "openclaw-abort-"));
+    const root = await suiteTempDirs.make("case");
     const storePath = path.join(root, "sessions.json");
     const cfg = {
       session: { store: storePath },
diff --git a/src/auto-reply/reply/session-hooks-context.test.ts b/src/auto-reply/reply/session-hooks-context.test.ts
@@ -1,11 +1,11 @@
 // Tests context passed to session lifecycle hooks.
 import fs from "node:fs/promises";
-import os from "node:os";
 import path from "node:path";
-import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
+import { afterAll, afterEach, beforeAll, beforeEach, describe, expect, it, vi } from "vitest";
 import type { OpenClawConfig } from "../../config/config.js";
 import type { SessionEntry } from "../../config/sessions.js";
 import type { HookRunner } from "../../plugins/hooks.js";
+import { createSuiteTempRootTracker } from "../../test-helpers/temp-dir.js";
 import { initSessionState } from "./session.js";
 
 const hookRunnerMocks = vi.hoisted(() => ({
@@ -61,8 +61,10 @@ vi.mock("../../agents/session-write-lock.js", async () => {
   };
 });
 
+const suiteTempDirs = createSuiteTempRootTracker({ prefix: "openclaw-session-hooks-" });
+
 async function createStorePath(prefix: string): Promise<string> {
-  const root = await fs.mkdtemp(path.join(os.tmpdir(), `${prefix}-`));
+  const root = await suiteTempDirs.make(prefix);
   return path.join(root, "sessions.json");
 }
 
@@ -165,6 +167,14 @@ function requireHookCall(
 }
 
 describe("session hook context wiring", () => {
+  beforeAll(async () => {
+    await suiteTempDirs.setup();
+  });
+
+  afterAll(async () => {
+    await suiteTempDirs.cleanup();
+  });
+
   beforeEach(() => {
     hookRunnerMocks.hasHooks.mockReset();
     hookRunnerMocks.runSessionStart.mockReset();
diff --git a/src/skills/lifecycle/install-fallback.test.ts b/src/skills/lifecycle/install-fallback.test.ts
@@ -1,8 +1,7 @@
 // Install fallback tests cover alternate skill install paths when primary paths fail.
-import fs from "node:fs/promises";
-import os from "node:os";
 import path from "node:path";
 import { afterAll, beforeAll, beforeEach, describe, expect, it, vi } from "vitest";
+import { createSuiteTempRootTracker } from "../../test-helpers/temp-dir.js";
 import { captureEnv } from "../../test-utils/env.js";
 import { hasBinaryMock, runCommandWithTimeoutMock } from "../test-support/install-test-mocks.js";
 import type { SkillEntry, SkillInstallSpec } from "../types.js";
@@ -82,11 +81,13 @@ function commandCallAt(
   ];
 }
 
+const suiteTempDirs = createSuiteTempRootTracker({ prefix: "openclaw-fallback-test-" });
+
 describe("skills-install fallback edge cases", () => {
   let workspaceDir: string;
 
   beforeAll(async () => {
-    workspaceDir = await fs.mkdtemp(path.join(os.tmpdir(), "openclaw-fallback-test-"));
+    workspaceDir = await suiteTempDirs.setup();
     skillsMocks.loadWorkspaceSkillEntries.mockReturnValue([
       makeSkillEntry(workspaceDir, "go-tool-single", {
         kind: "go",
@@ -112,7 +113,7 @@ describe("skills-install fallback edge cases", () => {
 
   afterAll(async () => {
     skillsInstallTesting.setDepsForTest();
-    await fs.rm(workspaceDir, { recursive: true, force: true }).catch(() => undefined);
+    await suiteTempDirs.cleanup();
   });
 
   it("handles sudo probe failures for go install without apt fallback", async () => {
