fix(msteams): sanitize internal tool-trace lines from outbound text (#90684)

claude · claude · commit 01243ccb14ec · 2026-07-13T16:18:57.000Z
Rebased onto current main. Adds a sanitizeAssistantVisibleText() hook to the msteams outbound adapter so internal failed-tool trace banners are stripped before delivery (mirrors the merged Google Chat fix #95084). The adapter tests pass a ReplyPayload-compatible payload and use a single string literal so the exact-head typecheck and lint pass. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
diff --git a/extensions/msteams/src/channel.message-adapter.test.ts b/extensions/msteams/src/channel.message-adapter.test.ts
@@ -25,7 +25,7 @@ vi.mock("./channel.runtime.js", () => ({
   },
 }));
 
-import { msteamsPlugin } from "./channel.js";
+import { msteamsChannelOutbound, msteamsPlugin } from "./channel.js";
 
 type MSTeamsMessageAdapter = NonNullable<typeof msteamsPlugin.message>;
 type MSTeamsMessageSender = NonNullable<MSTeamsMessageAdapter["send"]>;
@@ -226,3 +226,21 @@ describe("msteams channel message adapter", () => {
     });
   });
 });
+
+describe("msteams outbound sanitizeText", () => {
+  const sanitizeText = msteamsChannelOutbound.sanitizeText;
+
+  it("strips internal tool-trace failure banners from outbound text (#90684)", () => {
+    expect(sanitizeText).toBeDefined();
+    const text = "Listo, ya lo cargué.\n⚠️ 🛠️ `grep -E 'PV-123' /tmp/out.txt (agent)` failed";
+    const out = sanitizeText?.({ text, payload: { text } }) ?? text;
+    expect(out).toBe("Listo, ya lo cargué.");
+    expect(out).not.toContain("failed");
+    expect(out).not.toContain("🛠️");
+  });
+
+  it("preserves ordinary assistant prose untouched", () => {
+    const text = "La factura PV-123 quedó imputada en Bejerman.";
+    expect(sanitizeText?.({ text, payload: { text } }) ?? text).toBe(text);
+  });
+});
diff --git a/extensions/msteams/src/channel.ts b/extensions/msteams/src/channel.ts
@@ -28,6 +28,7 @@ import {
   normalizeOptionalString,
   normalizeStringEntries,
 } from "openclaw/plugin-sdk/string-coerce-runtime";
+import { sanitizeAssistantVisibleText } from "openclaw/plugin-sdk/text-chunking";
 import { Type } from "typebox";
 import type {
   ChannelMessageActionName,
@@ -479,11 +480,15 @@ function describeMSTeamsMessageTool({
   };
 }
 
-const msteamsChannelOutbound: ChannelOutboundAdapter = {
+export const msteamsChannelOutbound: ChannelOutboundAdapter = {
   deliveryMode: "direct",
   chunker: chunkTextForOutbound,
   chunkerMode: "markdown",
   textChunkLimit: 4000,
+  // Strip internal assistant trace lines (e.g. `⚠️ 🛠️ ... (agent) failed`
+  // banners from benign non-zero shell exits) before delivery, so they don't
+  // leak to users — mirrors Discord/Google Chat/WhatsApp outbound. See #90684.
+  sanitizeText: ({ text }: { text: string }) => sanitizeAssistantVisibleText(text),
   pollMaxOptions: 12,
   deliveryCapabilities: {
     durableFinal: {
