fix(qa): retain crabline delivery targets

vincentkoc · vincentkoc · commit 009d6b261aad · 2026-06-24T05:12:26.000+08:00
diff --git a/extensions/qa-lab/src/crabline-transport.test.ts b/extensions/qa-lab/src/crabline-transport.test.ts
@@ -115,6 +115,40 @@ describe("crabline transport", () => {
           direction: "outbound",
           text: "assistant via fake telegram",
         });
+
+        await transport.state.reset();
+        const delivery = transport.buildAgentDelivery({ target: "dm:qa-operator" });
+        const { response: directResponse, release: directRelease } = await fetchWithSsrFGuard({
+          url: `${telegram?.apiRoot}/bot${telegram?.botToken}/sendMessage`,
+          init: {
+            body: JSON.stringify({
+              chat_id: delivery.to,
+              text: "assistant after reset",
+            }),
+            headers: { "content-type": "application/json" },
+            method: "POST",
+          },
+          policy: { allowPrivateNetwork: true },
+          auditContext: "qa-lab-crabline-transport-reset-test",
+        });
+        await directRelease();
+        expect(directResponse.ok).toBe(true);
+
+        await expect(
+          transport.state.waitFor({
+            direction: "outbound",
+            kind: "message-text",
+            textIncludes: "assistant after reset",
+            timeoutMs: 1_000,
+          }),
+        ).resolves.toMatchObject({
+          conversation: {
+            id: "qa-operator",
+            kind: "direct",
+          },
+          direction: "outbound",
+          text: "assistant after reset",
+        });
       } finally {
         await transport.cleanup?.();
       }
diff --git a/extensions/qa-lab/src/crabline-transport.ts b/extensions/qa-lab/src/crabline-transport.ts
@@ -33,6 +33,7 @@ const RECORDER_SYNC_INTERVAL_MS = 50;
 
 type QaCrablineTransportState = QaTransportState & {
   cleanup: () => Promise<void>;
+  rememberProviderTarget: (providerTargetKey: string, qaTarget: string) => void;
 };
 
 async function waitForCrablineReady(params: {
@@ -193,6 +194,9 @@ function createCrablineState(params: {
       });
       return message;
     },
+    rememberProviderTarget(providerTargetKey, qaTarget) {
+      targetByProviderTarget.set(providerTargetKey, qaTarget);
+    },
     addOutboundMessage: baseState.addOutboundMessage.bind(baseState),
     readMessage: baseState.readMessage.bind(baseState),
     async searchMessages(input: QaBusSearchMessagesInput) {
@@ -247,8 +251,11 @@ class QaCrablineTransport extends QaStateBackedTransportAdapter {
       channel: this.#adapter.channel,
     });
 
-  buildAgentDelivery = ({ target }: { target: string }) =>
-    this.#adapter.createAgentDelivery({ target });
+  buildAgentDelivery = ({ target }: { target: string }) => {
+    const delivery = this.#adapter.createAgentDelivery({ target });
+    this.#state.rememberProviderTarget(delivery.to ?? delivery.replyTo, target);
+    return delivery;
+  };
 
   handleAction = async (_params: {
     action: QaTransportActionName;
