fix(test): scan QA Lab stdout artifacts incrementally

vincentkoc · vincentkoc · commit 005cc2a018ae · 2026-06-20T01:05:47.000+02:00
diff --git a/test/e2e/qa-lab/runtime/qa-otel-smoke-runtime.ts b/test/e2e/qa-lab/runtime/qa-otel-smoke-runtime.ts
@@ -158,6 +158,7 @@ const MAX_STDOUT_DIAGNOSTIC_LINE_BYTES = readPositiveIntegerEnv(
   "OPENCLAW_QA_OTEL_MAX_STDOUT_DIAGNOSTIC_LINE_BYTES",
   512 * 1024,
 );
+const GATEWAY_STDOUT_ARTIFACT_READ_CHUNK_BYTES = 64 * 1024;
 
 function readPositiveIntegerEnv(
   name: string,
@@ -1075,8 +1076,10 @@ async function appendGatewayStdoutArtifactLogs(params: {
     "gateway.stdout.log",
   );
   try {
-    params.capture.append(
-      await readUtf8FileTail(gatewayStdoutPath, MAX_STDOUT_DIAGNOSTIC_LINE_BYTES),
+    await appendUtf8FileToStdoutDiagnosticCapture(
+      gatewayStdoutPath,
+      params.capture,
+      GATEWAY_STDOUT_ARTIFACT_READ_CHUNK_BYTES,
     );
     params.capture.flush();
   } catch (error) {
@@ -1086,22 +1089,21 @@ async function appendGatewayStdoutArtifactLogs(params: {
   }
 }
 
-async function readUtf8FileTail(filePath: string, maxBytes: number): Promise<string> {
+async function appendUtf8FileToStdoutDiagnosticCapture(
+  filePath: string,
+  capture: ReturnType<typeof createStdoutDiagnosticLogCapture>,
+  chunkBytes = GATEWAY_STDOUT_ARTIFACT_READ_CHUNK_BYTES,
+): Promise<void> {
   const file = await open(filePath, "r");
   try {
-    const stats = await file.stat();
-    const bytesToRead = Math.min(stats.size, Math.max(1, maxBytes));
-    const buffer = Buffer.alloc(bytesToRead);
-    const start = stats.size - bytesToRead;
-    let offset = 0;
-    while (offset < bytesToRead) {
-      const { bytesRead } = await file.read(buffer, offset, bytesToRead - offset, start + offset);
+    const buffer = Buffer.alloc(Math.max(1, chunkBytes));
+    for (;;) {
+      const { bytesRead } = await file.read(buffer, 0, buffer.length);
       if (bytesRead === 0) {
         break;
       }
-      offset += bytesRead;
+      capture.append(buffer.subarray(0, bytesRead));
     }
-    return buffer.subarray(0, offset).toString("utf8");
   } finally {
     await file.close();
   }
@@ -1909,12 +1911,13 @@ export const testing = {
   appendCapturedBodyText,
   assertSmoke,
   createBoundedTextAccumulator,
+  createStdoutDiagnosticLogCapture,
   decodeRequestBody,
   parseArgs,
   parseStdoutDiagnosticLogLine,
   readPositiveIntegerEnv,
   readRequestBody,
-  readUtf8FileTail,
+  appendUtf8FileToStdoutDiagnosticCapture,
   startLocalOtlpReceiver,
   startDockerOtelCollector,
   terminateChildTree,
diff --git a/test/e2e/qa-lab/runtime/qa-otel-smoke.e2e.test.ts b/test/e2e/qa-lab/runtime/qa-otel-smoke.e2e.test.ts
@@ -501,19 +501,30 @@ describe("qa-otel-smoke receiver bounds", () => {
     expect(output.text()).not.toContain("DO_NOT_RETAIN_COLLECTOR_PREFIX");
   });
 
-  it("reads only a bounded tail from gateway stdout artifacts", async () => {
-    const tempRoot = mkdtempSync(path.join(os.tmpdir(), "openclaw-qa-otel-stdout-tail-"));
+  it("streams gateway stdout artifact records without requiring them in the tail", async () => {
+    const tempRoot = mkdtempSync(path.join(os.tmpdir(), "openclaw-qa-otel-stdout-stream-"));
     const logPath = path.join(tempRoot, "gateway.stdout.log");
+    const capture = testing.createStdoutDiagnosticLogCapture();
+    const record = {
+      signal: "openclaw.diagnostic.log",
+      ts: "2026-06-18T00:00:00.000Z",
+      "service.name": "openclaw-qa-lab-otel-smoke",
+      severityText: "INFO",
+      severityNumber: 9,
+      body: "early log",
+      attributes: {},
+    };
     try {
       writeFileSync(
         logPath,
-        `DO_NOT_RETAIN_GATEWAY_STDOUT_PREFIX\n${"x".repeat(2048)}\nGATEWAY_STDOUT_TAIL\n`,
+        `${JSON.stringify(record)}\n${"x".repeat(256 * 1024)}\nGATEWAY_STDOUT_TAIL\n`,
       );
 
-      const text = await testing.readUtf8FileTail(logPath, 64);
+      await testing.appendUtf8FileToStdoutDiagnosticCapture(logPath, capture);
+      capture.flush();
 
-      expect(text).toContain("GATEWAY_STDOUT_TAIL");
-      expect(text).not.toContain("DO_NOT_RETAIN_GATEWAY_STDOUT_PREFIX");
+      expect(capture.records).toEqual([record]);
+      expect(capture.lines).toHaveLength(1);
     } finally {
       rmSync(tempRoot, { force: true, recursive: true });
     }
@@ -536,14 +547,14 @@ describe("qa-otel-smoke receiver bounds", () => {
       mkdirSync(artifactDir, { recursive: true });
       writeFileSync(
         path.join(artifactDir, "gateway.stdout.log"),
-        `DO_NOT_RETAIN_GATEWAY_STDOUT_PREFIX\n${"x".repeat(2048)}\n${JSON.stringify(record)}\n`,
+        `${JSON.stringify(record)}\n${"x".repeat(256 * 1024)}\n`,
       );
       const capture = testing.createStdoutDiagnosticLogCapture();
 
       await testing.appendGatewayStdoutArtifactLogs({ capture, outputDir });
 
       expect(capture.records).toEqual([record]);
-      expect(capture.lines.join("\n")).not.toContain("DO_NOT_RETAIN_GATEWAY_STDOUT_PREFIX");
+      expect(capture.lines).toHaveLength(1);
     } finally {
       rmSync(tempRoot, { force: true, recursive: true });
     }
