-
-
Notifications
You must be signed in to change notification settings - Fork 80.8k
Expand file tree
/
Copy pathprovider-http-errors.test.ts
More file actions
322 lines (290 loc) · 9.79 KB
/
Copy pathprovider-http-errors.test.ts
File metadata and controls
322 lines (290 loc) · 9.79 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
// Verifies provider HTTP error parsing, redaction, and response-size limits.
import { describe, expect, it, vi } from "vitest";
import {
assertOkOrThrowProviderError,
assertOkOrThrowHttpError,
createProviderHttpError,
extractProviderErrorDetail,
extractProviderRequestId,
ProviderHttpError,
readProviderBinaryResponse,
readProviderJsonResponse,
readProviderTextResponse,
readResponseTextLimited,
} from "./provider-http-errors.js";
function createStreamingBinaryResponse(params: {
chunkCount: number;
chunkSize: number;
byte: number;
}): { response: Response; getReadCount: () => number } {
// Streaming fixture proves oversized binary reads stop before buffering everything.
let reads = 0;
const stream = new ReadableStream<Uint8Array>({
pull(controller) {
if (reads >= params.chunkCount) {
controller.close();
return;
}
reads += 1;
controller.enqueue(new Uint8Array(params.chunkSize).fill(params.byte));
},
});
return {
response: new Response(stream, {
status: 200,
headers: { "Content-Type": "audio/mpeg" },
}),
getReadCount: () => reads,
};
}
function createStreamingJsonResponse(params: { chunkCount: number; chunkSize: number }): {
response: Response;
getReadCount: () => number;
} {
// Streaming fixture proves oversized JSON reads stop before buffering everything.
let reads = 0;
const encoder = new TextEncoder();
const stream = new ReadableStream<Uint8Array>({
pull(controller) {
if (reads >= params.chunkCount) {
controller.close();
return;
}
reads += 1;
controller.enqueue(encoder.encode("a".repeat(params.chunkSize)));
},
});
return {
response: new Response(stream, {
status: 200,
headers: { "Content-Type": "application/json" },
}),
getReadCount: () => reads,
};
}
function createStreamingTextResponse(params: { chunkCount: number; chunkSize: number }): {
response: Response;
getReadCount: () => number;
} {
let reads = 0;
const encoder = new TextEncoder();
const stream = new ReadableStream<Uint8Array>({
pull(controller) {
if (reads >= params.chunkCount) {
controller.close();
return;
}
reads += 1;
controller.enqueue(encoder.encode("x".repeat(params.chunkSize)));
},
});
return {
response: new Response(stream, {
status: 200,
headers: { "Content-Type": "text/plain" },
}),
getReadCount: () => reads,
};
}
describe("provider error utils", () => {
it("formats nested provider error details with request ids", async () => {
const response = new Response(
JSON.stringify({
detail: {
message: "Quota exceeded",
status: "quota_exceeded",
},
}),
{
status: 429,
headers: { "x-request-id": "req_123" },
},
);
await expect(assertOkOrThrowProviderError(response, "Provider API error")).rejects.toThrow(
"Provider API error (429): Quota exceeded [code=quota_exceeded] [request_id=req_123]",
);
});
it("reads string error fields and fallback request id headers", async () => {
const response = new Response(JSON.stringify({ error: "Invalid API key" }), {
status: 401,
headers: { "request-id": "fallback_req" },
});
expect(await extractProviderErrorDetail(response)).toBe("Invalid API key");
expect(extractProviderRequestId(response)).toBe("fallback_req");
});
it("preserves OAuth error descriptions as actionable details", async () => {
const response = new Response(
JSON.stringify({
error: "invalid_request",
error_description: "AADSTS7000215: Invalid client secret provided.",
}),
{ status: 400 },
);
await expect(
assertOkOrThrowProviderError(response, "OAuth token exchange failed"),
).rejects.toThrow(
"OAuth token exchange failed (400): AADSTS7000215: Invalid client secret provided. [code=invalid_request]",
);
});
it("keeps HTTP status metadata when error body reads fail", async () => {
const response = {
ok: false,
status: 503,
headers: new Headers(),
body: {
getReader: () => ({
read: async () => {
throw new Error("broken response stream");
},
cancel: async () => undefined,
}),
},
} as unknown as Response;
await expect(
assertOkOrThrowProviderError(response, "Provider API error"),
).rejects.toMatchObject({
name: "ProviderHttpError",
status: 503,
statusCode: 503,
message: "Provider API error (503)",
} satisfies Partial<ProviderHttpError>);
});
it("releases provider error body reader locks after bounded reads complete", async () => {
const releaseLock = vi.fn();
const cancel = vi.fn(async () => undefined);
const chunks: Array<ReadableStreamReadResult<Uint8Array>> = [
{ done: false, value: new TextEncoder().encode("provider error") },
{ done: true, value: undefined },
];
const response = {
body: {
getReader: () => ({
read: async () => chunks.shift() ?? { done: true, value: undefined },
cancel,
releaseLock,
}),
},
} as unknown as Response;
await expect(readResponseTextLimited(response, 64)).resolves.toBe("provider error");
expect(cancel).not.toHaveBeenCalled();
expect(releaseLock).toHaveBeenCalledTimes(1);
});
it("cancels and releases provider error body readers after diagnostic truncation", async () => {
const releaseLock = vi.fn();
const cancel = vi.fn(async () => undefined);
const response = {
body: {
getReader: () => ({
read: async () => ({ done: false, value: new TextEncoder().encode("provider error") }),
cancel,
releaseLock,
}),
},
} as unknown as Response;
await expect(readResponseTextLimited(response, 8)).resolves.toBe("provider");
expect(cancel).toHaveBeenCalledTimes(1);
expect(releaseLock).toHaveBeenCalledTimes(1);
});
it("attaches structured provider error metadata", async () => {
// API-key-like substrings must be redacted from stored error bodies.
const response = new Response(
JSON.stringify({
error: {
message: "Quota exceeded for api_key=sk-secret1234567890abcd",
type: "rate_limit_error",
code: "insufficient_quota",
},
}),
{
status: 429,
headers: { "x-request-id": "req_456" },
},
);
const error = await createProviderHttpError(response, "Provider API error");
expect(error).toMatchObject({
name: "ProviderHttpError",
status: 429,
statusCode: 429,
code: "insufficient_quota",
errorCode: "insufficient_quota",
errorType: "rate_limit_error",
requestId: "req_456",
} satisfies Partial<ProviderHttpError>);
const providerError = error as ProviderHttpError;
expect(providerError.message).toContain("Quota exceeded");
expect(providerError.errorBody).toContain("Quota exceeded");
expect(providerError.errorBody).not.toContain("sk-secret1234567890abcd");
});
it("keeps legacy HTTP status formatting while sharing provider parsing", async () => {
const response = new Response(
JSON.stringify({
error: {
message: "Bad request",
code: "invalid_request",
},
}),
{
status: 400,
headers: { "x-request-id": "req_legacy" },
},
);
await expect(assertOkOrThrowHttpError(response, "Legacy provider error")).rejects.toThrow(
"Legacy provider error (HTTP 400): Bad request [code=invalid_request] [request_id=req_legacy]",
);
});
it("wraps malformed successful JSON responses with provider labels", async () => {
const response = new Response("{ nope", {
status: 200,
headers: { "content-type": "application/json" },
});
await expect(readProviderJsonResponse(response, "Provider catalog failed")).rejects.toThrow(
"Provider catalog failed: malformed JSON response",
);
});
it("parses well-formed JSON responses under the byte cap", async () => {
const response = new Response(JSON.stringify({ models: ["a", "b"] }), {
status: 200,
headers: { "content-type": "application/json" },
});
await expect(
readProviderJsonResponse<{ models: string[] }>(response, "Provider catalog failed"),
).resolves.toEqual({ models: ["a", "b"] });
});
it("caps successful JSON responses instead of buffering oversized bodies", async () => {
const streamed = createStreamingJsonResponse({
chunkCount: 20,
chunkSize: 1024,
});
await expect(
readProviderJsonResponse(streamed.response, "Provider catalog failed", {
maxBytes: 2048,
}),
).rejects.toThrow("Provider catalog failed: JSON response exceeds 2048 bytes");
expect(streamed.getReadCount()).toBeLessThan(20);
});
it("caps successful text responses instead of buffering oversized bodies", async () => {
const streamed = createStreamingTextResponse({
chunkCount: 20,
chunkSize: 1024,
});
await expect(
readProviderTextResponse(streamed.response, "Provider text failed", {
maxBytes: 2048,
}),
).rejects.toThrow("Provider text failed: text response exceeds 2048 bytes");
expect(streamed.getReadCount()).toBeLessThan(20);
});
it("caps successful binary responses instead of buffering oversized bodies", async () => {
const streamed = createStreamingBinaryResponse({
chunkCount: 20,
chunkSize: 1024,
byte: 121,
});
await expect(
readProviderBinaryResponse(streamed.response, "Provider TTS failed", "audio", {
maxBytes: 2048,
}),
).rejects.toThrow("Provider TTS failed: audio response exceeds 2048 bytes");
expect(streamed.getReadCount()).toBeLessThan(20);
});
});