fix(poll): restore vote payload delivery (#150)

omarshahine · web-flow · commit 1560a678ce0f · 2026-07-02T03:33:21.000-07:00
Restore native poll vote delivery on macOS 26.4 by applying the Polls balloon and payload across the associated message and backing item. Add focused regression coverage and document the affected release boundary.

Co-authored-by: Omar Shahine &lt;10343873+omarshahine@users.noreply.github.com&gt;
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,9 @@
 
 ## 0.12.2 - Unreleased
 
+### Native Polls
+- fix: restore native poll vote delivery on macOS 26.4 by persisting the Polls balloon and payload across the responding message objects (#150, thanks @omarshahine).
+
 ## 0.12.1 - 2026-07-02
 
 ### Packaging
diff --git a/Sources/IMsgHelper/IMsgInjected.m b/Sources/IMsgHelper/IMsgInjected.m
@@ -2815,15 +2815,9 @@ static id buildPollVoteIMMessage(NSAttributedString *body,
     Class messageClass = NSClassFromString(@"IMMessage");
     if (!messageClass) return nil;
 
-    // No macOS 26 IMMessage initializer carries balloon + payload AND
-    // association together (verified by selector probe). Reactions prove the
-    // associated-message initializer persists association atomically, and
-    // balloon/payload set on the backing IMMessageItem persist (verified: an
-    // earlier item-first vote landed with the balloon intact, only the
-    // association — set via the wrap — was lost). So: init with association
-    // atomically, then stamp balloonBundleID + payloadData onto the message's
-    // own backing item (a real item from a direct init, not the transient one
-    // the messageFromIMMessageItem: wrap returns).
+    // No macOS 26 initializer carries the payload and association together.
+    // Build the association atomically, then stamp payload metadata across the
+    // message and backing item; macOS 26.4 splits the setters between them.
     SEL sel = @selector(initWithSender:time:text:messageSubject:fileTransferGUIDs:flags:error:guid:subject:associatedMessageGUID:associatedMessageType:associatedMessageRange:messageSummaryInfo:);
     if (![messageClass instancesRespondToSelector:sel]) return nil;
 
@@ -2857,8 +2851,6 @@ static id buildPollVoteIMMessage(NSAttributedString *body,
     id result = invokeReturningObject(inv);
     if (!result) return nil;
 
-    // Both values must land on one object. A partial stamp can emit an
-    // associated message that Messages cannot decode as a poll vote.
     NSString *balloonID = pollsBalloonBundleIdentifier();
     NSArray<id> *targets = @[result];
     SEL itemSel = NSSelectorFromString(@"_imMessageItem");
@@ -2868,14 +2860,19 @@ static id buildPollVoteIMMessage(NSAttributedString *body,
             if (item) targets = @[item, result];
         } @catch (__unused NSException *e) {}
     }
+    BOOL balloonStamped = NO;
+    BOOL payloadStamped = NO;
     for (id target in targets) {
-        if (![target respondsToSelector:@selector(setBalloonBundleID:)]
-            || ![target respondsToSelector:@selector(setPayloadData:)]) continue;
-        [target performSelector:@selector(setBalloonBundleID:) withObject:balloonID];
-        [target performSelector:@selector(setPayloadData:) withObject:payloadData];
-        return result;
+        if ([target respondsToSelector:@selector(setBalloonBundleID:)]) {
+            [target performSelector:@selector(setBalloonBundleID:) withObject:balloonID];
+            balloonStamped = YES;
+        }
+        if ([target respondsToSelector:@selector(setPayloadData:)]) {
+            [target performSelector:@selector(setPayloadData:) withObject:payloadData];
+            payloadStamped = YES;
+        }
     }
-    return nil;
+    return (balloonStamped && payloadStamped) ? result : nil;
 }
 
 /// `send-poll-vote`: cast a vote on an existing poll. Builds a Polls balloon
diff --git a/Tests/imsgTests/BridgeCommandRegistrationTests.swift b/Tests/imsgTests/BridgeCommandRegistrationTests.swift
@@ -150,7 +150,7 @@ func injectedHelperWiresNativePollSend() throws {
 }
 
 @Test
-func injectedHelperWiresFailClosedNativePollVote() throws {
+func injectedHelperBroadcastsFailClosedNativePollVoteMetadata() throws {
   let testFile = URL(fileURLWithPath: #filePath)
   let repoRoot =
     testFile
@@ -168,9 +168,17 @@ func injectedHelperWiresFailClosedNativePollVote() throws {
   #expect(sendVoteBody.contains("pollVoteMessageInitializerAvailable()"))
   #expect(!sendVoteBody.contains("pollPayloadMessageInitializerAvailable()"))
   #expect(voteBody.contains("associatedMessageType"))
-  #expect(voteBody.contains("setBalloonBundleID:"))
-  #expect(voteBody.contains("setPayloadData:"))
-  #expect(voteBody.contains("return nil;"))
+  #expect(voteBody.contains("BOOL balloonStamped = NO;"))
+  #expect(voteBody.contains("BOOL payloadStamped = NO;"))
+  #expect(
+    voteBody.contains("if ([target respondsToSelector:@selector(setBalloonBundleID:)])")
+  )
+  #expect(voteBody.contains("if ([target respondsToSelector:@selector(setPayloadData:)])"))
+  #expect(voteBody.contains("return (balloonStamped && payloadStamped) ? result : nil;"))
+  #expect(
+    !voteBody.contains(
+      "|| ![target respondsToSelector:@selector(setPayloadData:)]"
+    ))
 }
 
 @Test
diff --git a/docs/history.md b/docs/history.md
@@ -92,6 +92,9 @@ poll's stable option identifier before sending:
 imsg poll vote --chat-id <id> --poll <poll-guid> --option-index 2
 ```
 
+On macOS 26.4, use imsg 0.12.2 or later. Earlier builds could create a local
+vote row without the Polls payload, so the recipient's poll did not update.
+
 ### Manual native poll test plan
 
 1. Create a native poll in Messages from an iPhone or Mac.
