feat(drive): add recursive directory push#927
Conversation
|
Codex review: needs real behavior proof before merge. Reviewed July 16, 2026, 9:47 AM ET / 13:47 UTC. Summary Reproducibility: not applicable. This PR proposes a new Drive capability rather than fixing a reproducible current-main bug. Review metrics: 3 noteworthy metrics.
Root-cause cluster Members:
Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything. Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Proof guidance:
Risk before merge
Maintainer options:
Next step before merge
Maintainer decision needed
Security Review findings
Review detailsBest possible solution: The desired end state is a sponsored, bounded push-only command with stable JSON/plain output, no remote deletion, preflight conflict checks, inspectable live proof, and release notes curated outside the contributor branch. Do we have a high-confidence way to reproduce the issue? Not applicable: this PR proposes a new Drive capability rather than fixing a reproducible current-main bug. Is this the best way to solve the issue? Unclear: the push-only design is substantially narrower and safer than the prior broad sync PR, but a maintainer must confirm that this permanent command surface is the preferred core solution. Full review comments:
Overall correctness: patch is correct AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 7785477091f9. Label changesLabel changes:
Label justifications:
Evidence reviewedWhat I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
Co-authored-by: xapids <[email protected]>
e69828a to
8aa8cf1
Compare
Summary
gog drive sync push <localDirectory> --parent <folderId>for recursive, non-destructive uploadsFixes #925.
Maintainer repair
The original proposal and live contract came from @Avg8888. The implementation was rewritten after maintainer review to close fail-closed, filesystem-race, bounded-resource, output-safety, and shared-drive gaps. Contributor co-authorship is preserved in the commit and changelog.
Proof
make ciSigned candidate SHA-256:
d226a155192d9dd727d453fda94498c52b90b40a6ceecf1f308e3c1df558a944