Skip to content

fix(calendar): display event-local times in event timezone#905

Closed
Hilo-Hilo wants to merge 1 commit into
openclaw:mainfrom
Hilo-Hilo:fix/calendar-event-timezone-display
Closed

fix(calendar): display event-local times in event timezone#905
Hilo-Hilo wants to merge 1 commit into
openclaw:mainfrom
Hilo-Hilo:fix/calendar-event-timezone-display

Conversation

@Hilo-Hilo

@Hilo-Hilo Hilo-Hilo commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Prefer an event's own start.timeZone / end.timeZone when computing local display fields (startLocal, endLocal, day-of-week, plain table output)
  • Fall back to the containing calendar timezone only when the event has no valid timezone
  • Add a regression test for an Asia/Seoul event on an Asia/Hong_Kong calendar, where Google may return the DateTime with the calendar offset while preserving the event timezone

Why

Google Calendar events can carry a different timezone from the parent calendar. For example, an ICML conference event stored as Asia/Seoul on an Asia/Hong_Kong calendar may be returned as:

{
  "dateTime": "2026-07-07T07:30:00+08:00",
  "timeZone": "Asia/Seoul"
}

That instant is 2026-07-07T08:30:00+09:00 in the event's own timezone. The current display path prefers the calendar timezone, so the derived local fields/table display can look one hour early for travel/conference events.

Test plan

  • go test ./internal/cmd
  • go test ./internal/cmd ./internal/...

@clawsweeper

clawsweeper Bot commented Jul 6, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

ClawSweeper review: did not complete due to Codex infrastructure failure. Reviewed July 6, 2026, 7:57 PM ET / 23:57 UTC.

Summary
Review failed before ClawSweeper could summarize the requested change.

Reproducibility: unclear. The review failed before ClawSweeper could establish a reproduction path.

Review metrics: none identified.

Merge readiness
Not assessed.
Failure reason: timeout.

This is a ClawSweeper/Codex infrastructure failure, not a PR readiness or patch-quality verdict.
Keep any merge decision on the normal maintainer review path until ClawSweeper can complete a fresh review.

Risk before merge

  • [P1] No close action taken because the review did not complete.

Maintainer options:

  1. Decide the mitigation before merge
    Retry the Codex review after fixing the execution failure.
  2. Pause or close
    Do not merge this PR until maintainers decide whether the risk is worth taking.

Next step before merge

  • Review did not complete, so no work-lane recommendation was made.
Review details

Best possible solution:

Retry the Codex review after fixing the execution failure.

Do we have a high-confidence way to reproduce the issue?

Unclear. The review failed before ClawSweeper could establish a reproduction path.

Is this the best way to solve the issue?

Unclear. Retry the review first so ClawSweeper can evaluate the actual issue and fix direction.

AGENTS.md: unclear because the file could not be read completely.

Codex review notes: model internal, reasoning high; reviewed against a1977274de23.

Evidence reviewed

What I checked:

  • failure reason: timeout.
  • codex failure detail: Codex review failed for this PR: Codex process timed out after 1200000ms.
  • codex stderr: No stderr captured.
  • codex stdout: {"type":"thread.started","thread_id":"019f39cb-8224-7450-9dc3-97385cc9d7f3"}.
  • process error code: ETIMEDOUT.

Likely related people:

  • unknown: Codex failed before it could trace repository history. (role: review did not complete; confidence: low)
How this review workflow works
  • ClawSweeper keeps one durable marker-backed review comment per issue or PR.
  • Re-runs edit this comment so the latest verdict, findings, and automation markers stay together instead of adding duplicate bot comments.
  • A fresh review can be triggered by eligible @clawsweeper re-review comments, exact-item GitHub events, scheduled/background review runs, or manual workflow dispatch.
  • PR/issue authors and users with repository write access can comment @clawsweeper re-review or @clawsweeper re-run on an open PR or issue to request a fresh review only.
  • Maintainers can also comment @clawsweeper review to request a fresh review only.
  • Fresh-review commands do not start repair, autofix, rebase, CI repair, or automerge.
  • Maintainer-only repair and merge flows require explicit commands such as @clawsweeper autofix, @clawsweeper automerge, @clawsweeper fix ci, or @clawsweeper address review.
  • Maintainers can comment @clawsweeper explain to ask for more context, or @clawsweeper stop to stop active automation.

@bxxd bxxd mentioned this pull request Jul 8, 2026
Closed
steipete added a commit that referenced this pull request Jul 11, 2026
@steipete @Hilo-Hilo
fix(calendar): display event-local times in event timezone (#905)
6790c6b 
Co-authored-by: Hanson Wen <[email protected]>
@steipete

steipete commented Jul 11, 2026

Copy link
Copy Markdown
Collaborator

Landed on main as 6790c6b. Thank you, @Hilo-Hilo!

Maintainer follow-up expanded the regression matrix for invalid/missing timezone fallback and corrected travel events whose start and end carry different timezones, so each endpoint's local time and weekday are resolved independently. Proof: focused timezone tests, full make ci, and clean autoreview.

@steipete steipete closed this Jul 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Hilo-Hilo @steipete