feat(sheets): add basic filter creation command#902
Conversation
|
Codex review: passed. Reviewed July 6, 2026, 2:03 AM ET / 06:03 UTC. Summary Reproducibility: not applicable. as a bug reproduction; this is a feature implementation PR. Source search on current main and v0.32.0 confirms there is no existing Sheets basic-filter command, and this PR is the linked implementation candidate. Review metrics: 2 noteworthy metrics.
Root-cause cluster Members:
Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything. Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Risk before merge
Maintainer options:
Next step before merge
Security Review detailsBest possible solution: Land the bounded command after required checks pass, preserving the replacement guard, generated docs, and no release-owned changelog edit. Do we have a high-confidence way to reproduce the issue? Not applicable as a bug reproduction; this is a feature implementation PR. Source search on current main and v0.32.0 confirms there is no existing Sheets basic-filter command, and this PR is the linked implementation candidate. Is this the best way to solve the issue? Yes: the PR reuses existing Sheets range resolution and mutation patterns, adds dry-run and replacement confirmation behavior, and includes generated docs plus focused tests. I found no duplicate supported command path on current main or the latest release. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 088198a28077. Label changesLabel justifications:
Evidence reviewedWhat I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
Review history (4 earlier review cycles)
|
dba7ddb to
d6253e9
Compare
|
🦞🔧 Repair: kept the fix on this contributor branch instead of opening a replacement PR. Current state: exact-head review queued immediately; GitHub checks and the review verdict gate final merge. Automerge progress:
|
|
Landed in Validation:
The maintainer follow-up also guards replacement of an existing sheet filter behind confirmation or |
Summary
gog sheets filter set <spreadsheetId> <range>for creating a Sheets basic filter.SetBasicFilterRequestthroughSpreadsheets.BatchUpdate, with dry-run and JSON output matching neighboring Sheets mutation commands.make docs-commands.Validation
make fmtgo test ./internal/cmd -run 'TestSheetsFilter|TestDryRunE2E_CommandsSkipAuthAPIAndFileWrites'make docs-commandsmake ciCloses #899