feat(docs): list pending suggestions#896
Conversation
|
Codex review: needs maintainer review before merge. Reviewed July 3, 2026, 9:37 AM ET / 13:37 UTC. Summary Reproducibility: not applicable. as a bug reproduction; this is a feature PR for a missing Docs suggestions surface. Source inspection confirms current main lacks the command and any Review metrics: 3 noteworthy metrics.
Root-cause cluster Members:
Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything. Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Risk before merge
Maintainer options:
Next step before merge
Security Review detailsBest possible solution: Land after maintainers explicitly accept the read-only command/output contract and the safe-profile exposure, keeping accept/reject mutation and style-only suggestions out of this PR. Do we have a high-confidence way to reproduce the issue? Not applicable as a bug reproduction; this is a feature PR for a missing Docs suggestions surface. Source inspection confirms current main lacks the command and any Is this the best way to solve the issue? Yes, if maintainers accept the product and safety scope: a dedicated read-only AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 65e1c851ee5f. Label changesLabel changes:
Label justifications:
Evidence reviewedSecurity concerns:
What I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
eed3903 to
d0e30f7
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d0e30f7ef2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
d0e30f7 to
3b20615
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3b2061527e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bf87d4b189
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Closes #876.
Summary
gog docs suggestions list <docId> [--tab title-or-id]SUGGESTIONS_INLINEexplicitly and emit pending insertions/deletions with suggestion ID, segment, UTF-16 range, and text when presentStyle-only suggestions and accept/reject mutation remain intentionally out of scope. The Docs API response does not expose suggestion authors.
Exact-head proof
cdcd3019d9951e3de6314c5a37982b54987948a6make cipassedv0.31.2-0.20260703130353-cdcd3019d995; SHA-256d8942a7bcb8b42dd942ee77e49ca96f9c95b0b59fa2ff1072b3e48df89ad8167docs suggestions list[email protected]: default-tab JSON, explicit-tab JSON, and plain reads passed; Drive modified time stayed unchanged; all temporary documents were trashedLive-proof limit
Google's Docs API can read but cannot create a pending suggestion. The existing-profile Chrome bridge had no attached tabs, so an authenticated UI-created pending insertion/deletion could not be induced safely. Empty live reads, tab projection, read-only behavior, and cleanup are live-proven; actual pending-suggestion rendering is API-type-exhaustive and fixture-proven rather than backed by a live pending suggestion.