feat(docs): add table header row pinning#862
Conversation
|
Codex review: needs maintainer review before merge. Reviewed June 20, 2026, 6:08 PM ET / 22:08 UTC. Summary Reproducibility: not applicable. as a bug reproduction; this is a feature PR. Source inspection confirms current main lacks a pin-header command, while the PR adds that surface. Review metrics: 3 noteworthy metrics.
Root-cause cluster Members:
Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything. Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Risk before merge
Maintainer options:
Next step before merge
Security Review detailsBest possible solution: Land the focused command after maintainer command-shape confirmation and green CI, preserving the existing table selector, tab, dry-run, revision-control, output, docs, and test patterns. Do we have a high-confidence way to reproduce the issue? Not applicable as a bug reproduction; this is a feature PR. Source inspection confirms current main lacks a pin-header command, while the PR adds that surface. Is this the best way to solve the issue? Yes, pending maintainer acceptance of the public command shape. The implementation follows the existing Docs table selection, tab targeting, revision-controlled request, output, test, and generated-doc patterns. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 42017c5e8ca8. Label changesLabel changes:
Label justifications:
Evidence reviewedWhat I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
Summary
docs table-row pin-header --rows Nfor pinning the first N table rows or unpinning with--rows 0docs table-row style, removing duplicate output codeCloses #855.
Validation
make ci[email protected]: created disposable native Docs tables; validated dry-run; pinned one and two leading rows; confirmedtableHeaderstate throughdocs raw; unpinned with zero and confirmed all header state cleared