feat(docs): add paragraph list formatting#859
Conversation
|
ClawSweeper status: review started. I am starting a fresh review of this pull request: feat(docs): add paragraph list formatting This is item 1/1 in the current shard. Shard 0/1. This placeholder means the worker is alive and reading the current context. I will edit this same comment with the actual review when the claws are done clicking. Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 97b36bc2ae
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| } | ||
|
|
||
| func (c *DocsWriteCmd) writePlainText(ctx context.Context, flags *RootFlags, docID, text string) error { | ||
| if c.Append && c.Format.createsBullets() && c.Format.hasParagraphStyle() { |
There was a problem hiding this comment.
Reject append bullets or move the range past the break
This guard still allows docs write --append --bullets without paragraph-style flags, but the formatter later builds the CreateParagraphBullets range starting at the append index. In the common case --text '\nItem', that range includes the inserted newline that terminates the existing last paragraph, so Docs treats the previous paragraph as overlapping the range and turns it into a list item too; either disallow append bullet creation or start the bullet range after the leading paragraph break.
Useful? React with 👍 / 👎.
|
Landed as 360310f. Proof:
|
Closes #852.
Summary
docs formatdocs write, with a guarded append workflowTesting
make ci