feat(docs): add layout-preserving image replacement#858
Conversation
|
Codex review: needs maintainer review before merge. Reviewed June 19, 2026, 1:41 PM ET / 17:41 UTC. Summary Reproducibility: not applicable. this is a feature PR, not a reported current-main bug. Source inspection shows current main lacks the dedicated command while the related issue describes the desired workflow. Review metrics: 3 noteworthy metrics.
Root-cause cluster Members:
Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything. Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Risk before merge
Maintainer options:
Next step before merge
Security Review detailsBest possible solution: Review and land this PR if the remaining CI and maintainer validation are acceptable, keeping the related issue open until the candidate fix merges. Do we have a high-confidence way to reproduce the issue? Not applicable: this is a feature PR, not a reported current-main bug. Source inspection shows current main lacks the dedicated command while the related issue describes the desired workflow. Is this the best way to solve the issue? Yes: the PR takes a narrow path by adding a dedicated command while reusing existing image enumeration and upload helpers. The remaining question is ordinary merge validation, not a different implementation direction. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against ab9a331d4c07. Label changesLabel changes:
Label justifications:
Evidence reviewedWhat I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
|
Landed as 91c0bcb. Verification:
Caveat: the local-file path was not externally uploaded during live proof. Its Drive upload, temporary public permission, Docs replacement, and permission revocation sequence is covered end-to-end with mocked Drive and Docs services. |
Summary
docs replace-imagewith exact object-ID, case-insensitive alt substring, or implicit single-image selectionReplaceImageRequestwithCENTER_CROPCloses #853.
Verification
go test ./internal/cmd -run 'Docs.*Image|DocsImages|DocsSed'go test ./internal/docssed ./internal/docseditmake ciThe local-file path has full mocked Drive upload, public-share, Docs replacement, and permission-revoke coverage. No additional external image upload was performed during live proof.