Skip to content

feat(slides): add table sizing and styling#848

Merged
steipete merged 2 commits into
mainfrom
feat/slides-table-visuals
Jun 19, 2026
Merged

feat(slides): add table sizing and styling#848
steipete merged 2 commits into
mainfrom
feat/slides-table-visuals

Conversation

@steipete

Copy link
Copy Markdown
Collaborator

Summary

  • add revision-locked table row minimum-height and column-width commands
  • add atomic table cell fill, vertical alignment, and text styling
  • add range-scoped table border styling with generated command docs

Fixes #824.

Verification

  • make ci
  • focused table request, validation, and revision-lock tests
  • Codex autoreview: clean, no accepted/actionable findings
  • live Slides create/style/read/delete lifecycle under the project test account
  • raw provider readback verified dimensions, fill, alignment, text style, and borders
  • cleanup query verified zero temporary Slides decks remained

@clawsweeper

clawsweeper Bot commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Codex review: needs maintainer review before merge. Reviewed June 19, 2026, 6:31 AM ET / 10:31 UTC.

Summary
The PR adds Slides table row/column sizing, table cell fill/alignment/text styling, range-scoped table border styling, generated command docs, focused tests, live-test coverage, and a changelog entry.

Reproducibility: not applicable. as a feature PR. Source inspection and the linked issue show current main lacks the final sizing, border, and cell styling commands that this branch adds.

Review metrics: 2 noteworthy metrics.

  • Diff size: 18 files, +1041/-13. The PR spans CLI code, generated docs, focused tests, and live smoke coverage, so maintainers should review behavior and generated surface together.
  • Generated command pages: 6 added. The generated command index grows from 673 to 679 pages for the new schema-visible Slides table commands.

Root-cause cluster
Relationship: fixed_by_candidate
Canonical: #824
Summary: This PR is the candidate final visual-table implementation for the canonical Slides native table command issue; earlier merged PRs covered prior slices of the same feature request.

Members:

Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything.

Merge readiness
Overall: 🐚 platinum hermit
Proof: 🐚 platinum hermit
Patch quality: 🦞 diamond lobster
Result: ready for maintainer review.

Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch.

Rank-up moves:

  • [P2] Wait for the exact-head CI rollup to finish cleanly before merge.

Mantis proof suggestion
A visible Slides proof would materially show rendered sizing, fill, text style, and border behavior beyond API readback. A maintainer can ask Mantis to capture proof by posting this exact PR comment:

@openclaw-mantis visual task: create a Slides table, apply row and column sizing, cell fill/text styling, and border styling, then show the rendered result and raw readback.

Risk before merge

  • [P1] The GitHub PR rollup was still UNSTABLE with some exact-head CI jobs in progress when checked, so maintainers should wait for the required checks before merge.
  • [P1] The PR body reports live Google Slides lifecycle and raw-provider readback proof, but this read-only review did not independently rerun live Google API tests.

Maintainer options:

  1. Decide the mitigation before merge
    Land this final Slides table visual slice after maintainer review and clean exact-head checks, preserving the existing revision-locked mutation pattern, generated docs, and live provider coverage.
  2. Pause or close
    Do not merge this PR until maintainers decide whether the risk is worth taking.

Next step before merge

  • [P2] This collaborator-authored feature PR has no concrete automated repair target; maintainers should review the implementation and merge only after exact-head checks are clean.

Security
Cleared: The diff adds Google Slides command code, generated docs, tests, and an existing live-test script extension; no dependency, workflow, credential, permission, or supply-chain concern was found.

Review details

Best possible solution:

Land this final Slides table visual slice after maintainer review and clean exact-head checks, preserving the existing revision-locked mutation pattern, generated docs, and live provider coverage.

Do we have a high-confidence way to reproduce the issue?

Not applicable as a feature PR. Source inspection and the linked issue show current main lacks the final sizing, border, and cell styling commands that this branch adds.

Is this the best way to solve the issue?

Yes. The PR extends the existing Slides table group and shared revision-locked mutation helper rather than adding a parallel path, with focused request tests and live-script coverage for the new surface.

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning high; reviewed against 9f9c2ce4b635.

Label changes

Label justifications:

  • P2: This is a bounded user-facing Slides automation feature tied to an open P2 issue with limited blast radius.
  • rating: 🐚 platinum hermit: Overall readiness is 🐚 platinum hermit; proof is 🐚 platinum hermit and patch quality is 🦞 diamond lobster.
  • status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR. Not applicable: The external-contributor proof gate does not apply because this is a collaborator-authored PR; the body nevertheless reports make ci plus live Slides lifecycle and raw readback verification.
Evidence reviewed

What I checked:

  • Repository policy read: AGENTS.md was read fully and applied as read-only PR review guidance, including using gh pr view/diff without switching branches or editing files. (AGENTS.md:1, 9f9c2ce4b635)
  • Current main lacks this final command surface: Current main's Slides table command group exposes create, row, column, merge, and unmerge, but has no cell or border subgroup and row/column help still only covers insert/delete. (internal/cmd/slides_table.go:14, 9f9c2ce4b635)
  • PR registers the new table visual commands: The PR extends the existing Slides table group with cell and border subcommands and adds row/column sizing under the existing row/column groups. (internal/cmd/slides_table.go:14, 7a8fe5c8f4a9)
  • PR implements the requested mutations: The added style implementation builds row minimum-height, column width, cell property/text-style, and table border update requests through the existing revision-locked table mutation path. (internal/cmd/slides_table_style.go:69, 7a8fe5c8f4a9)
  • Focused tests cover request shape and revision lock: The added tests verify dry-run request construction for row/column sizing, cell styling, border styling, local validation, and the revision lock on the atomic cell style batch. (internal/cmd/slides_table_style_test.go:16, 7a8fe5c8f4a9)
  • Live smoke coverage was extended: The PR extends the Slides live test script to create a table, size row/column dimensions, write and style a cell, style borders, then raw-read provider state to assert the rendered properties. (scripts/live-tests/slides.sh:35, 7a8fe5c8f4a9)

Likely related people:

  • steipete: Git blame and log show Peter Steinberger authored the current main Slides table creation and structural table operation commits that this PR extends. (role: recent area contributor; confidence: high; commits: c78e609203f9, 9f9c2ce4b635; files: internal/cmd/slides_table.go, internal/cmd/slides_table_structure.go, docs/slides-tables.md)
  • Chris Sanchez: Git history shows Chris Sanchez introduced the Slides insert-text and replace-text command path whose table-cell targeting is part of the broader Slides table surface. (role: introduced related text behavior; confidence: medium; commits: d047a0325f12; files: internal/cmd/slides_insert_text.go, internal/cmd/slides_text_edit.go, internal/cmd/slides.go)
  • Chris Parsons: Git history shows Chris Parsons authored earlier merged Slides command surface work, making this a secondary routing signal for Slides CLI patterns. (role: adjacent Slides command contributor; confidence: medium; commits: 8b08d11777fe; files: internal/cmd/slides.go)
What the crustacean ranks mean
  • 🦀 challenger crab: rare, exceptional readiness with strong proof, clean implementation, and convincing validation.
  • 🦞 diamond lobster: very strong readiness with only minor maintainer review expected.
  • 🐚 platinum hermit: good normal PR, likely mergeable with ordinary maintainer review.
  • 🦐 gold shrimp: useful signal, but proof or patch confidence is still limited.
  • 🦪 silver shellfish: thin signal; proof, validation, or implementation needs work.
  • 🧂 unranked krab: not merge-ready because proof is missing/unusable or there are serious correctness or safety concerns.
  • 🌊 off-meta tidepool: rating does not apply to this item.

Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics.

How this review workflow works
  • ClawSweeper keeps one durable marker-backed review comment per issue or PR.
  • Re-runs edit this comment so the latest verdict, findings, and automation markers stay together instead of adding duplicate bot comments.
  • A fresh review can be triggered by eligible @clawsweeper re-review comments, exact-item GitHub events, scheduled/background review runs, or manual workflow dispatch.
  • PR/issue authors and users with repository write access can comment @clawsweeper re-review or @clawsweeper re-run on an open PR or issue to request a fresh review only.
  • Maintainers can also comment @clawsweeper review to request a fresh review only.
  • Fresh-review commands do not start repair, autofix, rebase, CI repair, or automerge.
  • Maintainer-only repair and merge flows require explicit commands such as @clawsweeper autofix, @clawsweeper automerge, @clawsweeper fix ci, or @clawsweeper address review.
  • Maintainers can comment @clawsweeper explain to ask for more context, or @clawsweeper stop to stop active automation.

@clawsweeper clawsweeper Bot added rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. P2 Normal priority bug or improvement with limited blast radius. labels Jun 19, 2026
@steipete
steipete merged commit 971c637 into main Jun 19, 2026
9 checks passed
@steipete
steipete deleted the feat/slides-table-visuals branch June 19, 2026 10:41
@steipete

Copy link
Copy Markdown
Collaborator Author

Landed in 971c63788d397308e0b2bd5367e230933f70283d.

Proof:

  • local make ci passed
  • Codex autoreview returned no accepted/actionable findings
  • live Slides lifecycle passed under the project test account, including raw provider readback for row/column sizing, cell fill/alignment/text style, and borders
  • cleanup query found zero temporary Slides decks
  • all PR checks passed on exact head 7a8fe5c8f4a9c0e8290bb320fb2ae0a13a0cd9c5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P2 Normal priority bug or improvement with limited blast radius. rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

slides: no native table command surface (parallel to docs table tooling)

1 participant