feat(slides): add structural table operations#847
Conversation
|
Codex review: needs maintainer review before merge. Reviewed June 19, 2026, 5:29 AM ET / 09:29 UTC. Summary Reproducibility: not applicable. as a bug reproduction. Source inspection confirms current main only has Review metrics: 2 noteworthy metrics.
Root-cause cluster Members:
Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything. Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Risk before merge
Maintainer options:
Next step before merge
Security Review detailsBest possible solution: Review and land this structural Slides table slice if required checks pass, while keeping #824 open for the remaining table styling and sizing work. Do we have a high-confidence way to reproduce the issue? Not applicable as a bug reproduction. Source inspection confirms current main only has Is this the best way to solve the issue? Yes. Extending the existing AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against eda03e04a4fb. Label changesLabel justifications:
Evidence reviewedWhat I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
|
Landed as Proof:
#824 remains open for the separate sizing, borders, and cell-style slice. |
Summary
Testing
go test ./internal/cmd -run 'TestSlidesTable' -count=1make ci[email protected]: create table, insert row/column, merge/read back, unmerge, delete row/column, read back, delete deckgogcli-smoke-slides-*artifactsRefs #824. Sizing, borders, and cell styling remain a separate follow-up slice.