feat(slides): add native element operations#846
Conversation
|
Codex review: needs maintainer review before merge. Reviewed June 19, 2026, 4:14 AM ET / 08:14 UTC. Summary Reproducibility: not applicable. this is a feature PR for a known missing command surface rather than a bug reproduction. Source inspection confirms current main lacks the Review metrics: 2 noteworthy metrics.
Root-cause cluster Members:
Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything. Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Risk before merge
Maintainer options:
Next step before merge
Security Review detailsBest possible solution: Keep this PR open for maintainer review, run the live Slides element lifecycle with the required keyring password or another authenticated account, then merge if the command surface and provider proof are accepted. Do we have a high-confidence way to reproduce the issue? Not applicable: this is a feature PR for a known missing command surface rather than a bug reproduction. Source inspection confirms current main lacks the Is this the best way to solve the issue? Yes, with merge gating: a focused batchUpdate-backed element subtree matches the linked issue and existing Slides command patterns. The remaining requirement is maintainer acceptance plus live Google Slides proof after credentials are available. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against b3c285613b74. Label changesLabel changes:
Label justifications:
Evidence reviewedAcceptance criteria:
What I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
Summary
slides elementcommands for shape/line creation, affine transforms, styling, z-order, grouping, alt text, and guarded deletionCloses #826.
Testing
make cigo test ./internal/cmd -run 'TestSlidesElement' -count=1--dry-run --jsonrequest checks[email protected]; blocked before API access because the encrypted file keyring requiresGOG_KEYRING_PASSWORDin this non-interactive session