feat(docs): add tab-aware raw output#722
Conversation
|
Codex review: needs maintainer review before merge. Reviewed June 10, 2026, 12:24 AM ET / 04:24 UTC. Summary Reproducibility: not applicable. as a PR feature review; the linked issue has concrete CLI reproduction steps, and this PR adds tests plus a live Google Docs smoke summary for the new behavior. Review metrics: 2 noteworthy metrics.
Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Risk before merge
Maintainer options:
Next step before merge
Security Review detailsBest possible solution: Land the focused tab-aware raw-output implementation after normal maintainer review, keeping default raw output backward-compatible and preserving the canonical all-tabs response. Do we have a high-confidence way to reproduce the issue? Not applicable as a PR feature review; the linked issue has concrete CLI reproduction steps, and this PR adds tests plus a live Google Docs smoke summary for the new behavior. Is this the best way to solve the issue? Yes, the PR uses the existing Docs tab resolution helpers and keeps the unflagged raw request unchanged while adding explicit selected-tab and canonical all-tabs modes. AGENTS.md: found and applied where relevant. Codex review notes: model gpt-5.5, reasoning high; reviewed against ebc8218b609a. Label changesLabel changes:
Label justifications:
Evidence reviewedWhat I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
Summary
docs raw --tab <title-or-id>for one selected tab in the existing top-level Document shapedocs raw --all-tabsfor the canonical recursive tabs responseFixes #697.
Validation
DEVELOPER_DIR=/Library/Developer/CommandLineTools make ciDEVELOPER_DIR=/Library/Developer/CommandLineTools go test ./internal/cmd -run '^Test(DocsRaw|ProjectRawDocumentTab)' -count=1[email protected]:tabs--all-tabsreturned all three tabs recursively