-
Notifications
You must be signed in to change notification settings - Fork 656
bug(calendar): freebusy rejects relative dates that events accepts #806
Copy link
Copy link
Closed
Labels
P2Normal priority bug or improvement with limited blast radius.Normal priority bug or improvement with limited blast radius.clawsweeper:fix-shape-clearClawSweeper found a clear likely implementation shape for this issue.ClawSweeper found a clear likely implementation shape for this issue.clawsweeper:queueable-fixClawSweeper marked this issue as an existing queue_fix_pr work candidate.ClawSweeper marked this issue as an existing queue_fix_pr work candidate.clawsweeper:source-reproClawSweeper found a high-confidence source-level issue reproduction.ClawSweeper found a high-confidence source-level issue reproduction.impact:otherThis issue has meaningful maintainer-visible impact outside the owned taxonomy.This issue has meaningful maintainer-visible impact outside the owned taxonomy.issue-rating: 🦞 diamond lobsterVery strong issue quality with high-confidence source-level or clear reproduction.Very strong issue quality with high-confidence source-level or clear reproduction.no-staleExempts this issue from stale automation.Exempts this issue from stale automation.
Description
Metadata
Metadata
Assignees
Labels
P2Normal priority bug or improvement with limited blast radius.Normal priority bug or improvement with limited blast radius.clawsweeper:fix-shape-clearClawSweeper found a clear likely implementation shape for this issue.ClawSweeper found a clear likely implementation shape for this issue.clawsweeper:queueable-fixClawSweeper marked this issue as an existing queue_fix_pr work candidate.ClawSweeper marked this issue as an existing queue_fix_pr work candidate.clawsweeper:source-reproClawSweeper found a high-confidence source-level issue reproduction.ClawSweeper found a high-confidence source-level issue reproduction.impact:otherThis issue has meaningful maintainer-visible impact outside the owned taxonomy.This issue has meaningful maintainer-visible impact outside the owned taxonomy.issue-rating: 🦞 diamond lobsterVery strong issue quality with high-confidence source-level or clear reproduction.Very strong issue quality with high-confidence source-level or clear reproduction.no-staleExempts this issue from stale automation.Exempts this issue from stale automation.
Type
Fields
Priority
None yet
Summary
gog calendar events --from/--toaccept relative date expressions (today,tomorrow,monday,now, plain dates), butgog calendar freebusy --from/--toare forwarded raw to theAPI and require RFC3339, so the same expressions fail. Inconsistent and surprising.
Repro
Root cause (v0.22.0, 197992a)
eventsresolves--from/--tovia the shared parsertimeparse.ParseRangeExpr(
internal/cmd/time_helpers.go:257); flags documented as "RFC3339 with timezone, date, orrelative: now, today, tomorrow, monday" (
docs/commands/gog-calendar-events.md:37,54).freebusypasses raw strings straight through:TimeMin: c.From/TimeMax: c.To(
internal/cmd/calendar_freebusy.go:38-39); help says "RFC3339, required" (:19-20).Suggested fix
Route
freebusy--from/--tothrough the sameParseRangeExprhelper asevents(resolving inthe calendar's timezone), and update the flag help. Recommend auditing other date-taking calendar
commands (e.g.
conflicts) for the same gap.Environment
gog v0.22.0 (confirmed by reading source at
197992a).