Skip to content

Commit 30fa959

Browse files
fix(cli): mention all-pages flags in next-page hint
Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com>
1 parent 23b847c commit 30fa959

42 files changed

Lines changed: 58 additions & 50 deletions

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

docs/refactor/output.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ Use `internal/cmd/output_helpers.go:printNextPageHint(u, token)`:
2727

2828
- prints to stderr
2929
- exact format (tests depend on it): `# Next page: --page <token>`
30+
- for commands that support full-page fetch, use `printNextPageHintWithAll(u, token, flags)` with the exact supported flag text, e.g. `# More results: use --all/--all-pages to fetch every page, or --page <token> for the next page`
3031

3132
## Result (Key-Value) Output
3233

internal/cmd/admin_groups.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ func (c *AdminGroupsListCmd) Run(ctx context.Context, flags *RootFlags) error {
103103
if err := outfmt.WriteTable(ctx, stdoutWriter(ctx), nonNilAdminRows(groups), adminGroupColumns()); err != nil {
104104
return err
105105
}
106-
printNextPageHint(u, nextPageToken)
106+
printNextPageHintWithAll(u, nextPageToken, "--all/--all-pages")
107107
return nil
108108
}
109109

@@ -196,7 +196,7 @@ func (c *AdminGroupsMembersListCmd) Run(ctx context.Context, flags *RootFlags) e
196196
if err := outfmt.WriteTable(ctx, stdoutWriter(ctx), nonNilAdminRows(members), adminMemberColumns()); err != nil {
197197
return err
198198
}
199-
printNextPageHint(u, nextPageToken)
199+
printNextPageHintWithAll(u, nextPageToken, "--all/--all-pages")
200200
return nil
201201
}
202202

internal/cmd/admin_users.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ func (c *AdminUsersListCmd) Run(ctx context.Context, flags *RootFlags) error {
113113
if err := outfmt.WriteTable(ctx, stdoutWriter(ctx), nonNilAdminRows(users), adminUserColumns()); err != nil {
114114
return err
115115
}
116-
printNextPageHint(u, nextPageToken)
116+
printNextPageHintWithAll(u, nextPageToken, "--all/--all-pages")
117117
return nil
118118
}
119119

internal/cmd/analytics.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ func (c *AnalyticsAccountsCmd) Run(ctx context.Context, flags *RootFlags) error
9797
len(item.PropertySummaries),
9898
)
9999
}
100-
printNextPageHint(u, nextPageToken)
100+
printNextPageHintWithAll(u, nextPageToken, "--all/--all-pages")
101101
return nil
102102
}
103103

internal/cmd/calendar_list.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -201,7 +201,7 @@ func renderCalendarEventsTable(ctx context.Context, events []*eventWithCalendar,
201201
return err
202202
}
203203
if printPageHint {
204-
printNextPageHint(u, nextPageToken)
204+
printNextPageHintWithAll(u, nextPageToken, "--all-pages")
205205
}
206206
return nil
207207
}

internal/cmd/calendar_list_cmds.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ func (c *CalendarCalendarsCmd) Run(ctx context.Context, flags *RootFlags) error
7373
); err != nil {
7474
return err
7575
}
76-
printNextPageHint(u, nextPageToken)
76+
printNextPageHintWithAll(u, nextPageToken, "--all/--all-pages")
7777
return nil
7878
}
7979

@@ -210,6 +210,6 @@ func (c *CalendarAclCmd) Run(ctx context.Context, flags *RootFlags) error {
210210
); err != nil {
211211
return err
212212
}
213-
printNextPageHint(u, nextPageToken)
213+
printNextPageHintWithAll(u, nextPageToken, "--all/--all-pages")
214214
return nil
215215
}

internal/cmd/calendar_users.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ func (c *CalendarUsersCmd) Run(ctx context.Context, flags *RootFlags) error {
108108
if err := outfmt.WriteTable(ctx, stdoutWriter(ctx), rows, calendarUserColumns()); err != nil {
109109
return err
110110
}
111-
printNextPageHint(u, nextPageToken)
111+
printNextPageHintWithAll(u, nextPageToken, "--all/--all-pages")
112112

113113
u.Err().Println("\nTip: Use any email above as a calendar ID, e.g.:")
114114
if len(rows) > 0 {

internal/cmd/chat_messages.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,7 @@ func (c *ChatMessagesListCmd) Run(ctx context.Context, flags *RootFlags) error {
142142
); err != nil {
143143
return err
144144
}
145-
printNextPageHint(u, nextPageToken)
145+
printNextPageHintWithAll(u, nextPageToken, "--all/--all-pages")
146146
return nil
147147
}
148148

internal/cmd/chat_reactions.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -169,7 +169,7 @@ func (c *ChatMessagesReactionsListCmd) Run(ctx context.Context, flags *RootFlags
169169
); err != nil {
170170
return err
171171
}
172-
printNextPageHint(u, nextPageToken)
172+
printNextPageHintWithAll(u, nextPageToken, "--all")
173173
return nil
174174
}
175175

internal/cmd/chat_spaces.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ func (c *ChatSpacesListCmd) Run(ctx context.Context, flags *RootFlags) error {
104104
); err != nil {
105105
return err
106106
}
107-
printNextPageHint(u, nextPageToken)
107+
printNextPageHintWithAll(u, nextPageToken, "--all/--all-pages")
108108
return nil
109109
}
110110

0 commit comments

Comments
 (0)