style(update): satisfy fallback lint

steipete · steipete · commit 0df2cb33b8c3 · 2026-07-01T08:29:42.000+01:00
diff --git a/internal/cmd/update.go b/internal/cmd/update.go
@@ -188,16 +188,16 @@ func updateClient(timeout time.Duration) *http.Client {
 	return &clone
 }
 
-func fetchLatestGitHubRelease(ctx context.Context, client *http.Client, url string) (githubRelease, error) {
+func fetchLatestGitHubRelease(ctx context.Context, client *http.Client, endpoint string) (githubRelease, error) {
 	var release githubRelease
-	apiErr := fetchUpdateJSON(ctx, client, url, &release)
+	apiErr := fetchUpdateJSON(ctx, client, endpoint, &release)
 	if apiErr == nil {
 		return release, nil
 	}
 
 	fallback, fallbackErr := fetchLatestGitHubReleaseRedirect(ctx, client, updateLatestWebURL)
 	if fallbackErr != nil {
-		return githubRelease{}, fmt.Errorf("fetch latest release: API: %v; web fallback: %w", apiErr, fallbackErr)
+		return githubRelease{}, fmt.Errorf("fetch latest release: API: %s; web fallback: %w", apiErr.Error(), fallbackErr)
 	}
 	return fallback, nil
 }
@@ -258,8 +258,8 @@ func updateReleaseAssetURL(tag string, assetName string) string {
 		url.PathEscape(tag) + "/" + url.PathEscape(assetName)
 }
 
-func fetchUpdateJSON(ctx context.Context, client *http.Client, url string, dst any) error {
-	req, err := http.NewRequestWithContext(ctx, http.MethodGet, url, nil)
+func fetchUpdateJSON(ctx context.Context, client *http.Client, endpoint string, dst any) error {
+	req, err := http.NewRequestWithContext(ctx, http.MethodGet, endpoint, nil)
 	if err != nil {
 		return err
 	}
@@ -285,8 +285,8 @@ func fetchUpdateJSON(ctx context.Context, client *http.Client, url string, dst a
 	return nil
 }
 
-func fetchAssetChecksum(ctx context.Context, client *http.Client, url string, assetName string) (string, error) {
-	req, err := http.NewRequestWithContext(ctx, http.MethodGet, url, nil)
+func fetchAssetChecksum(ctx context.Context, client *http.Client, endpoint string, assetName string) (string, error) {
+	req, err := http.NewRequestWithContext(ctx, http.MethodGet, endpoint, nil)
 	if err != nil {
 		return "", fmt.Errorf("fetch checksums.txt: %w", err)
 	}

Original file line number	Diff line number	Diff line change
`@@ -188,16 +188,16 @@ func updateClient(timeout time.Duration) *http.Client {`
`188`	`188`	`return &clone`
`189`	`189`	`}`
`190`	`190`
`191`		`-func fetchLatestGitHubRelease(ctx context.Context, client *http.Client, url string) (githubRelease, error) {`
	`191`	`+func fetchLatestGitHubRelease(ctx context.Context, client *http.Client, endpoint string) (githubRelease, error) {`
`192`	`192`	`var release githubRelease`
`193`		`- apiErr := fetchUpdateJSON(ctx, client, url, &release)`
	`193`	`+ apiErr := fetchUpdateJSON(ctx, client, endpoint, &release)`
`194`	`194`	`if apiErr == nil {`
`195`	`195`	`return release, nil`
`196`	`196`	`}`
`197`	`197`
`198`	`198`	`fallback, fallbackErr := fetchLatestGitHubReleaseRedirect(ctx, client, updateLatestWebURL)`
`199`	`199`	`if fallbackErr != nil {`
`200`		`- return githubRelease{}, fmt.Errorf("fetch latest release: API: %v; web fallback: %w", apiErr, fallbackErr)`
	`200`	`+ return githubRelease{}, fmt.Errorf("fetch latest release: API: %s; web fallback: %w", apiErr.Error(), fallbackErr)`
`201`	`201`	`}`
`202`	`202`	`return fallback, nil`
`203`	`203`	`}`
`@@ -258,8 +258,8 @@ func updateReleaseAssetURL(tag string, assetName string) string {`
`258`	`258`	`url.PathEscape(tag) + "/" + url.PathEscape(assetName)`
`259`	`259`	`}`
`260`	`260`
`261`		`-func fetchUpdateJSON(ctx context.Context, client *http.Client, url string, dst any) error {`
`262`		`- req, err := http.NewRequestWithContext(ctx, http.MethodGet, url, nil)`
	`261`	`+func fetchUpdateJSON(ctx context.Context, client *http.Client, endpoint string, dst any) error {`
	`262`	`+ req, err := http.NewRequestWithContext(ctx, http.MethodGet, endpoint, nil)`
`263`	`263`	`if err != nil {`
`264`	`264`	`return err`
`265`	`265`	`}`
`@@ -285,8 +285,8 @@ func fetchUpdateJSON(ctx context.Context, client *http.Client, url string, dst a`
`285`	`285`	`return nil`
`286`	`286`	`}`
`287`	`287`
`288`		`-func fetchAssetChecksum(ctx context.Context, client *http.Client, url string, assetName string) (string, error) {`
`289`		`- req, err := http.NewRequestWithContext(ctx, http.MethodGet, url, nil)`
	`288`	`+func fetchAssetChecksum(ctx context.Context, client *http.Client, endpoint string, assetName string) (string, error) {`
	`289`	`+ req, err := http.NewRequestWithContext(ctx, http.MethodGet, endpoint, nil)`
`290`	`290`	`if err != nil {`
`291`	`291`	`return "", fmt.Errorf("fetch checksums.txt: %w", err)`
`292`	`292`	`}`