Skip to content

Add publish plugin submission success modal#3141

Merged
vyctorbrzezowski merged 7 commits into
openclaw:mainfrom
nancymx-dev:nmxdesign/plugin-submission-modal
Jul 18, 2026
Merged

Add publish plugin submission success modal#3141
vyctorbrzezowski merged 7 commits into
openclaw:mainfrom
nancymx-dev:nmxdesign/plugin-submission-modal

Conversation

@nancymx-dev

@nancymx-dev nancymx-dev commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Summary

Adding missing interaction for publish plugin submission. Filled in the gap in the user experience when there is no feedback for when a user presses the publish plugin CTA button.

What Changed

  • Created publish plugin submission modal based on publish skill success modal design system
  • This publish plugin button would appear when user presses the publish plugin button and would direct user straight to the plugin page.

Screenshots

Plugin submission modal design
Plugin submitted modal on the ClawHub plugin publishing page

@vercel

vercel Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

@nancymx-dev is attempting to deploy a commit to the OpenClaw Foundation Team on Vercel.

A member of the Team first needs to authorize it.

@nancymx-dev nancymx-dev changed the title Add plugin submission review modal Add plugin submission success modal Jul 17, 2026
@clawsweeper

clawsweeper Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Codex review: stale review; fresh review needed.

Summary
The latest durable ClawSweeper review was for head 9df53a8ff2e2c046c6bf027262fc0077e3dc9b83, but the PR head is now c19c9fe690c18d0f0222f03f0f86773db3507499. Its old verdict and PR readiness labels are no longer current.

Next step
Run or wait for a fresh ClawSweeper review on the current PR head.

@nancymx-dev
nancymx-dev marked this pull request as ready for review July 17, 2026 13:18
@nancymx-dev
nancymx-dev requested a review from a team as a code owner July 17, 2026 13:18
@nancymx-dev nancymx-dev changed the title Add plugin submission success modal Add publish plugin submission success modal Jul 17, 2026
@clawsweeper

clawsweeper Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

ClawSweeper status: review started.

I am starting a fresh review of this pull request: Add publish plugin submission success modal This is item 1/1 in the current shard. Shard 0/1.

This placeholder means the worker is alive and reading the current context. I will edit this same comment with the actual review when the claws are done clicking.

Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted.

@vyctorbrzezowski vyctorbrzezowski self-assigned this Jul 18, 2026
@vyctorbrzezowski
vyctorbrzezowski force-pushed the nmxdesign/plugin-submission-modal branch from c99b584 to dce5eec Compare July 18, 2026 01:51
@vyctorbrzezowski

vyctorbrzezowski commented Jul 18, 2026

Copy link
Copy Markdown
Member

ClawHub UI Proof

Status: pass
Mode: feature
Scenario: PR #3141 muted submission icons
Provider: local-browser
Baseline: not run for feature proof.
Candidate: 4efe8f39

Skill success modal - dark

Skill success modal - dark

Skill success modal - light

Skill success modal - light

Plugin submitted modal - dark

Plugin submitted modal - dark

Plugin submitted modal - light

Plugin submitted modal - light

Raw proof files: https://github.com/openclaw/clawhub/tree/qa-artifacts/clawhub-ui-proof/pr-3141/pr-3141-local-20260717-223208

@vyctorbrzezowski
vyctorbrzezowski force-pushed the nmxdesign/plugin-submission-modal branch from dce5eec to 4efe8f3 Compare July 18, 2026 01:59

@vyctorbrzezowski vyctorbrzezowski left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This adds the missing success state after publishing a plugin and brings its marketplace icon treatment in line with the muted skill/plugin language used elsewhere in ClawHub. It closes a real feedback gap in the publish flow while keeping the sibling skill-success surface consistent.

LOC: +805/-51 (11 files)

No blocking findings after maintainer follow-ups.

Resolved during review:

  • Muted the plugin submission icon and the sibling skill-success icon through an explicit shared MarketplaceIcon tone.
  • Kept pending plugin submissions disabled after the modal closes, preventing accidental duplicate resubmission.
  • Preserved the canonical https://clawhub.ai fallback for local, invalid, and opaque site origins.
  • Removed the duplicated public-site URL logic from the two dialogs.

Evidence checked: real local ClawHub + local Convex flow in Chromium, plugin ZIP uploaded through /plugins/publish, seeded skill success flow, dark/light screenshots in the UI proof comment, 58 focused tests, clean maintainer autoreview, and 28 green checks on 4efe8f39. Vercel is the sole expected failure because the contributor deployment is not authorized.

Best-fix verdict: best fix. The explicit muted tone keeps the component default intact for contexts that still need emphasis, while the shared URL helper and route-state fix place behavior at their owning layers.

Alternatives considered: changing the global marketplace-icon default would affect unrelated emphasized contexts; styling each dialog locally would duplicate the design invariant and drift again.

Code read: plugin publish route and tests, both success dialogs, MarketplaceIcon, shared site URL helpers, adjacent styles, and the sibling skill-detail success path.

Remaining uncertainty: the Vercel preview is unavailable due to authorization, so visual proof comes from the real local full-stack app. ClawSweeper dispatch passed but did not emit a fresh verdict for the final head; the manual maintainer review and autoreview are clean.

Provenance: feature and PR by Nancy (@nancymx-dev); maintainer follow-ups by Vyctor; PR #3141; reviewed July 17, 2026.

Thank you, Nancy — the modal foundation was thoughtful and closed an important gap in the publish experience.

@vyctorbrzezowski
vyctorbrzezowski merged commit aaa7362 into openclaw:main Jul 18, 2026
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants