Add publish plugin submission success modal#3141
Conversation
|
@nancymx-dev is attempting to deploy a commit to the OpenClaw Foundation Team on Vercel. A member of the Team first needs to authorize it. |
|
Codex review: stale review; fresh review needed. Summary Next step |
|
ClawSweeper status: review started. I am starting a fresh review of this pull request: Add publish plugin submission success modal This is item 1/1 in the current shard. Shard 0/1. This placeholder means the worker is alive and reading the current context. I will edit this same comment with the actual review when the claws are done clicking. Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted. |
c99b584 to
dce5eec
Compare
ClawHub UI ProofStatus: Skill success modal - dark Skill success modal - light Plugin submitted modal - dark Plugin submitted modal - light |
dce5eec to
4efe8f3
Compare
vyctorbrzezowski
left a comment
There was a problem hiding this comment.
This adds the missing success state after publishing a plugin and brings its marketplace icon treatment in line with the muted skill/plugin language used elsewhere in ClawHub. It closes a real feedback gap in the publish flow while keeping the sibling skill-success surface consistent.
LOC: +805/-51 (11 files)
No blocking findings after maintainer follow-ups.
Resolved during review:
- Muted the plugin submission icon and the sibling skill-success icon through an explicit shared
MarketplaceIcontone. - Kept pending plugin submissions disabled after the modal closes, preventing accidental duplicate resubmission.
- Preserved the canonical
https://clawhub.aifallback for local, invalid, and opaque site origins. - Removed the duplicated public-site URL logic from the two dialogs.
Evidence checked: real local ClawHub + local Convex flow in Chromium, plugin ZIP uploaded through /plugins/publish, seeded skill success flow, dark/light screenshots in the UI proof comment, 58 focused tests, clean maintainer autoreview, and 28 green checks on 4efe8f39. Vercel is the sole expected failure because the contributor deployment is not authorized.
Best-fix verdict: best fix. The explicit muted tone keeps the component default intact for contexts that still need emphasis, while the shared URL helper and route-state fix place behavior at their owning layers.
Alternatives considered: changing the global marketplace-icon default would affect unrelated emphasized contexts; styling each dialog locally would duplicate the design invariant and drift again.
Code read: plugin publish route and tests, both success dialogs, MarketplaceIcon, shared site URL helpers, adjacent styles, and the sibling skill-detail success path.
Remaining uncertainty: the Vercel preview is unavailable due to authorization, so visual proof comes from the real local full-stack app. ClawSweeper dispatch passed but did not emit a fresh verdict for the final head; the manual maintainer review and autoreview are clean.
Provenance: feature and PR by Nancy (@nancymx-dev); maintainer follow-ups by Vyctor; PR #3141; reviewed July 17, 2026.
Thank you, Nancy — the modal foundation was thoughtful and closed an important gap in the publish experience.




Summary
Adding missing interaction for publish plugin submission. Filled in the gap in the user experience when there is no feedback for when a user presses the publish plugin CTA button.
What Changed
Screenshots
Plugin submission modal design
