[Bug] Session retention hint still describes the old "Only archived sessions" checkbox #5680

Activity

1. openchamber-bot commented on Oct 26, 2026

   

   openchamber-botBot

   on Oct 26, 2026

   Contributor

   More actions

   For the maintainer: fix-ready — cause traced

   Your analysis is right, and the trace confirms the symptom exactly: the hint string you quoted matches packages/ui/src/lib/i18n/messages/en.settings.ts:1139 (onlyArchivedDescription) character for character, and it is confirmed — not just plausible — that this is what the reporter sees.

   Mechanism: SessionRetentionSettings.tsx:115 passes info={t('settings.openchamber.sessionRetention.field.onlyArchivedDescription')} to the "Applies to" SettingsFieldRow unconditionally, while the row's chip group (:117-125) freely switches between unarchived and archived. The string was written for the old "Only archived sessions" checkbox, so it both contradicts the unarchived scope and hardcodes an action ("Uses Delete") that the selector itself controls (:168 disables Delete's Archive sibling when archived is selected). The retention engine backs your suggested copy: session-retention.ts:19-21 counts from time.archived for archived scope and time.updated/created otherwise.

   What's new beyond the report:

   • The section-level tooltip already branches correctly on onlyArchived (SessionRetentionSettings.tsx:87-89) — the row hint just needs the same branch with two new keys.
   • packages/ui/src/lib/settings/search.ts:667 reuses the stale onlyArchivedDescription as the settings-search description for this item, so a fix that touches only the component leaves the stale copy in search results.
   • Your "Related" point is also confirmed: isSessionKeptByUser (session-retention.ts:35-37) keeps in-work and pinned sessions, and neither sessionRetention.tooltip nor .archivedTooltip (en.settings.ts:1140-1141) mentions them.
   • The key exists in 14 non-English locale files; new keys will need matching entries (or deliberate English fallback) in each.

   Code path

   1. SessionRetentionSettings.tsx:112-126 — "Applies to" row: label from settings.layout.sessions.retention.target, info hardcoded to onlyArchivedDescription regardless of onlyArchived state.
   2. en.settings.ts:1139 — value: "Uses Delete and counts the retention period from archiving. Unarchived sessions are kept." (checkbox-era copy from 0e9e93d; 7bae0e7 swapped the checkbox for the selector without replacing the row hint).
   3. session-retention.ts:19-27, 51-59 — scope selects the timestamp source and the archive-vs-delete path, so the two suggested hint strings are semantically accurate.
   4. search.ts:667 — same key reused as the settings-search item description.
   5. en.settings.ts:1140-1141 vs session-retention.ts:35-37 — section tooltips omit pinned and in-work sessions from the kept list.

   Suggested copy from the report works as-is; renaming the key (e.g. field.appliesToDescriptionUnarchived / ...Archived) would also retire the misleading onlyArchived name.
2. openchamber-bot

   added

   bugSomething isn't workingSomething isn't working

   area:settingsSettings UI, config, preferencesSettings UI, config, preferences

   regressionBug that worked in a previous releaseBug that worked in a previous release

   root-cause:foundBot traced a concrete code-level cause (not yet confirmed by the reporter)Bot traced a concrete code-level cause (not yet confirmed by the reporter)

   on Oct 26, 2026
3. btriapitsyn

   added a commit that references this issue on Oct 30, 2026

   fix(settings): match retention hints to scope and action (#5714)

   ...

   This issue will close once commit bb2096a is merged into the 'main' branch.

   bb2096a
4. btriapitsyn

   closed this as completedin #5714on Oct 30, 2026