Set sender value in sent emails if set #6564
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Well, yes, I suppose so! At the very least, I can give it a shot. I haven't tested anything yet, and I'm not too familiar with it, but I'll definitely give it a try this week and report back |
stefanosgeo
reviewed
Mar 27, 2025
Contributor
There was a problem hiding this comment.
I I tested it as follows:
- I built the pr locally, skipping Maven tests (since my local FFmpeg installation lacks some required codecs).
- I transferred the allinone-tar archive to my test-vm, extracted it, and started Opencast with:
sudo -u opencast /opt/opencast/bin/start-opencast
- I received an email with the expected From header and a simple "Hello world" body:
Date: Thu, 27 Mar 2025 08:03:38 +0100 (CET)
From: rrze-opencast@*****.de
To: rrze-opencast@*****.de
Message-ID: <364652932.1.1743059018023@****.de>
Subject: Test from Opencast
- I haven’t tested the send-mail WOH yet, but I assume it uses the same MIME object and should also include the From header.
I believe we can merge it.Would it be okay to file the PR against the 16.x branch?
Member
Author
|
I'm going to close in this in favour of #6581 since this is based off my |
LukasKalbertodt
pushed a commit
to LukasKalbertodt/opencast
that referenced
this pull request
Apr 2, 2025
Bumps [axios](https://github.com/axios/axios) from 1.7.2 to 1.7.7. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/axios/axios/releases">axios's releases</a>.</em></p> <blockquote> <h2>Release v1.7.7</h2> <h2>Release notes:</h2> <h3>Bug Fixes</h3> <ul> <li><strong>fetch:</strong> fix stream handling in Safari by fallback to using a stream reader instead of an async iterator; (<a href="https://redirect.github.com/axios/axios/issues/6584">#6584</a>) (<a href="https://github.com/axios/axios/commit/d1980854fee1765cd02fa0787adf5d6e34dd9dcf">d198085</a>)</li> <li><strong>http:</strong> fixed support for IPv6 literal strings in url (<a href="https://redirect.github.com/axios/axios/issues/5731">#5731</a>) (<a href="https://github.com/axios/axios/commit/364993f0d8bc6e0e06f76b8a35d2d0a35cab054c">364993f</a>)</li> </ul> <h3>Contributors to this release</h3> <ul> <li><!-- raw HTML omitted --> <a href="https://github.com/Rishi556" title="+39/-1 ([opencast#5731](axios/axios#5731) )">Rishi556</a></li> <li><!-- raw HTML omitted --> <a href="https://github.com/DigitalBrainJS" title="+27/-7 ([opencast#6584](axios/axios#6584) )">Dmitriy Mozgovoy</a></li> </ul> <h2>Release v1.7.6</h2> <h2>Release notes:</h2> <h3>Bug Fixes</h3> <ul> <li><strong>fetch:</strong> fix content length calculation for FormData payload; (<a href="https://redirect.github.com/axios/axios/issues/6524">#6524</a>) (<a href="https://github.com/axios/axios/commit/085f56861a83e9ac02c140ad9d68dac540dfeeaa">085f568</a>)</li> <li><strong>fetch:</strong> optimize signals composing logic; (<a href="https://redirect.github.com/axios/axios/issues/6582">#6582</a>) (<a href="https://github.com/axios/axios/commit/df9889b83c2cc37e9e6189675a73ab70c60f031f">df9889b</a>)</li> </ul> <h3>Contributors to this release</h3> <ul> <li><!-- raw HTML omitted --> <a href="https://github.com/DigitalBrainJS" title="+98/-46 ([opencast#6582](axios/axios#6582) )">Dmitriy Mozgovoy</a></li> <li><!-- raw HTML omitted --> <a href="https://github.com/jacquesg" title="+5/-1 ([opencast#6524](axios/axios#6524) )">Jacques Germishuys</a></li> <li><!-- raw HTML omitted --> <a href="https://github.com/kuroino721" title="+3/-1 ([opencast#6575](axios/axios#6575) )">kuroino721</a></li> </ul> <h2>Release v1.7.5</h2> <h2>Release notes:</h2> <h3>Bug Fixes</h3> <ul> <li><strong>adapter:</strong> fix undefined reference to hasBrowserEnv (<a href="https://redirect.github.com/axios/axios/issues/6572">#6572</a>) (<a href="https://github.com/axios/axios/commit/7004707c4180b416341863bd86913fe4fc2f1df1">7004707</a>)</li> <li><strong>core:</strong> add the missed implementation of AxiosError#status property; (<a href="https://redirect.github.com/axios/axios/issues/6573">#6573</a>) (<a href="https://github.com/axios/axios/commit/6700a8adac06942205f6a7a21421ecb36c4e0852">6700a8a</a>)</li> <li><strong>core:</strong> fix <code>ReferenceError: navigator is not defined</code> for custom environments; (<a href="https://redirect.github.com/axios/axios/issues/6567">#6567</a>) (<a href="https://github.com/axios/axios/commit/fed1a4b2d78ed4a588c84e09d32749ed01dc2794">fed1a4b</a>)</li> <li><strong>fetch:</strong> fix credentials handling in Cloudflare workers (<a href="https://redirect.github.com/axios/axios/issues/6533">#6533</a>) (<a href="https://github.com/axios/axios/commit/550d885eb90fd156add7b93bbdc54d30d2f9a98d">550d885</a>)</li> </ul> <h3>Contributors to this release</h3> <ul> <li><!-- raw HTML omitted --> <a href="https://github.com/DigitalBrainJS" title="+187/-83 ([opencast#6573](axios/axios#6573) [opencast#6567](axios/axios#6567) [opencast#6566](axios/axios#6566) [opencast#6564](axios/axios#6564) [opencast#6563](axios/axios#6563) [opencast#6557](axios/axios#6557) [opencast#6556](axios/axios#6556) [opencast#6555](axios/axios#6555) [opencast#6554](axios/axios#6554) [opencast#6552](axios/axios#6552) )">Dmitriy Mozgovoy</a></li> <li><!-- raw HTML omitted --> <a href="https://github.com/antoninbas" title="+6/-6 ([opencast#6572](axios/axios#6572) )">Antonin Bas</a></li> <li><!-- raw HTML omitted --> <a href="https://github.com/hansottowirtz" title="+4/-1 ([opencast#6533](axios/axios#6533) )">Hans Otto Wirtz</a></li> </ul> <h2>Release v1.7.4</h2> <h2>Release notes:</h2> <h3>Bug Fixes</h3> <ul> <li><strong>sec:</strong> CVE-2024-39338 (<a href="https://redirect.github.com/axios/axios/issues/6539">#6539</a>) (<a href="https://redirect.github.com/axios/axios/issues/6543">#6543</a>) (<a href="https://github.com/axios/axios/commit/6b6b605eaf73852fb2dae033f1e786155959de3a">6b6b605</a>)</li> <li><strong>sec:</strong> disregard protocol-relative URL to remediate SSRF (<a href="https://redirect.github.com/axios/axios/issues/6539">#6539</a>) (<a href="https://github.com/axios/axios/commit/07a661a2a6b9092c4aa640dcc7f724ec5e65bdda">07a661a</a>)</li> </ul> <h3>Contributors to this release</h3> <ul> <li><!-- raw HTML omitted --> <a href="https://github.com/levpachmanov" title="+47/-11 ([opencast#6543](axios/axios#6543) )">Lev Pachmanov</a></li> </ul> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/axios/axios/blob/v1.x/CHANGELOG.md">axios's changelog</a>.</em></p> <blockquote> <h2><a href="https://github.com/axios/axios/compare/v1.7.6...v1.7.7">1.7.7</a> (2024-08-31)</h2> <h3>Bug Fixes</h3> <ul> <li><strong>fetch:</strong> fix stream handling in Safari by fallback to using a stream reader instead of an async iterator; (<a href="https://redirect.github.com/axios/axios/issues/6584">#6584</a>) (<a href="https://github.com/axios/axios/commit/d1980854fee1765cd02fa0787adf5d6e34dd9dcf">d198085</a>)</li> <li><strong>http:</strong> fixed support for IPv6 literal strings in url (<a href="https://redirect.github.com/axios/axios/issues/5731">#5731</a>) (<a href="https://github.com/axios/axios/commit/364993f0d8bc6e0e06f76b8a35d2d0a35cab054c">364993f</a>)</li> </ul> <h3>Contributors to this release</h3> <ul> <li><!-- raw HTML omitted --> <a href="https://github.com/Rishi556" title="+39/-1 ([opencast#5731](axios/axios#5731) )">Rishi556</a></li> <li><!-- raw HTML omitted --> <a href="https://github.com/DigitalBrainJS" title="+27/-7 ([opencast#6584](axios/axios#6584) )">Dmitriy Mozgovoy</a></li> </ul> <h2><a href="https://github.com/axios/axios/compare/v1.7.5...v1.7.6">1.7.6</a> (2024-08-30)</h2> <h3>Bug Fixes</h3> <ul> <li><strong>fetch:</strong> fix content length calculation for FormData payload; (<a href="https://redirect.github.com/axios/axios/issues/6524">#6524</a>) (<a href="https://github.com/axios/axios/commit/085f56861a83e9ac02c140ad9d68dac540dfeeaa">085f568</a>)</li> <li><strong>fetch:</strong> optimize signals composing logic; (<a href="https://redirect.github.com/axios/axios/issues/6582">#6582</a>) (<a href="https://github.com/axios/axios/commit/df9889b83c2cc37e9e6189675a73ab70c60f031f">df9889b</a>)</li> </ul> <h3>Contributors to this release</h3> <ul> <li><!-- raw HTML omitted --> <a href="https://github.com/DigitalBrainJS" title="+98/-46 ([opencast#6582](axios/axios#6582) )">Dmitriy Mozgovoy</a></li> <li><!-- raw HTML omitted --> <a href="https://github.com/jacquesg" title="+5/-1 ([opencast#6524](axios/axios#6524) )">Jacques Germishuys</a></li> <li><!-- raw HTML omitted --> <a href="https://github.com/kuroino721" title="+3/-1 ([opencast#6575](axios/axios#6575) )">kuroino721</a></li> </ul> <h2><a href="https://github.com/axios/axios/compare/v1.7.4...v1.7.5">1.7.5</a> (2024-08-23)</h2> <h3>Bug Fixes</h3> <ul> <li><strong>adapter:</strong> fix undefined reference to hasBrowserEnv (<a href="https://redirect.github.com/axios/axios/issues/6572">#6572</a>) (<a href="https://github.com/axios/axios/commit/7004707c4180b416341863bd86913fe4fc2f1df1">7004707</a>)</li> <li><strong>core:</strong> add the missed implementation of AxiosError#status property; (<a href="https://redirect.github.com/axios/axios/issues/6573">#6573</a>) (<a href="https://github.com/axios/axios/commit/6700a8adac06942205f6a7a21421ecb36c4e0852">6700a8a</a>)</li> <li><strong>core:</strong> fix <code>ReferenceError: navigator is not defined</code> for custom environments; (<a href="https://redirect.github.com/axios/axios/issues/6567">#6567</a>) (<a href="https://github.com/axios/axios/commit/fed1a4b2d78ed4a588c84e09d32749ed01dc2794">fed1a4b</a>)</li> <li><strong>fetch:</strong> fix credentials handling in Cloudflare workers (<a href="https://redirect.github.com/axios/axios/issues/6533">#6533</a>) (<a href="https://github.com/axios/axios/commit/550d885eb90fd156add7b93bbdc54d30d2f9a98d">550d885</a>)</li> </ul> <h3>Contributors to this release</h3> <ul> <li><!-- raw HTML omitted --> <a href="https://github.com/DigitalBrainJS" title="+187/-83 ([opencast#6573](axios/axios#6573) [opencast#6567](axios/axios#6567) [opencast#6566](axios/axios#6566) [opencast#6564](axios/axios#6564) [opencast#6563](axios/axios#6563) [opencast#6557](axios/axios#6557) [opencast#6556](axios/axios#6556) [opencast#6555](axios/axios#6555) [opencast#6554](axios/axios#6554) [opencast#6552](axios/axios#6552) )">Dmitriy Mozgovoy</a></li> <li><!-- raw HTML omitted --> <a href="https://github.com/antoninbas" title="+6/-6 ([opencast#6572](axios/axios#6572) )">Antonin Bas</a></li> <li><!-- raw HTML omitted --> <a href="https://github.com/hansottowirtz" title="+4/-1 ([opencast#6533](axios/axios#6533) )">Hans Otto Wirtz</a></li> </ul> <h2><a href="https://github.com/axios/axios/compare/v1.7.3...v1.7.4">1.7.4</a> (2024-08-13)</h2> <h3>Bug Fixes</h3> <ul> <li><strong>sec:</strong> CVE-2024-39338 (<a href="https://redirect.github.com/axios/axios/issues/6539">#6539</a>) (<a href="https://redirect.github.com/axios/axios/issues/6543">#6543</a>) (<a href="https://github.com/axios/axios/commit/6b6b605eaf73852fb2dae033f1e786155959de3a">6b6b605</a>)</li> <li><strong>sec:</strong> disregard protocol-relative URL to remediate SSRF (<a href="https://redirect.github.com/axios/axios/issues/6539">#6539</a>) (<a href="https://github.com/axios/axios/commit/07a661a2a6b9092c4aa640dcc7f724ec5e65bdda">07a661a</a>)</li> </ul> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/axios/axios/commit/5b8a826771b77ab30081d033fdba9ef3b90e439a"><code>5b8a826</code></a> chore(release): v1.7.7 (<a href="https://redirect.github.com/axios/axios/issues/6585">#6585</a>)</li> <li><a href="https://github.com/axios/axios/commit/364993f0d8bc6e0e06f76b8a35d2d0a35cab054c"><code>364993f</code></a> fix(http): fixed support for IPv6 literal strings in url (<a href="https://redirect.github.com/axios/axios/issues/5731">#5731</a>)</li> <li><a href="https://github.com/axios/axios/commit/d1980854fee1765cd02fa0787adf5d6e34dd9dcf"><code>d198085</code></a> fix(fetch): fix stream handling in Safari by fallback to using a stream reade...</li> <li><a href="https://github.com/axios/axios/commit/d584fcfa62ba5217baf2be0748b7c5eda6da16ad"><code>d584fcf</code></a> chore(release): v1.7.6 (<a href="https://redirect.github.com/axios/axios/issues/6583">#6583</a>)</li> <li><a href="https://github.com/axios/axios/commit/bc03c6cbc41eb8449daa2f4b6b8048671a05bded"><code>bc03c6c</code></a> chore(examples): fix module import (<a href="https://redirect.github.com/axios/axios/issues/6575">#6575</a>)</li> <li><a href="https://github.com/axios/axios/commit/df9889b83c2cc37e9e6189675a73ab70c60f031f"><code>df9889b</code></a> fix(fetch): optimize signals composing logic; (<a href="https://redirect.github.com/axios/axios/issues/6582">#6582</a>)</li> <li><a href="https://github.com/axios/axios/commit/ee208cfcae8770ac579f26e7278867567886e026"><code>ee208cf</code></a> chore(sponsor): update sponsor block (<a href="https://redirect.github.com/axios/axios/issues/6576">#6576</a>)</li> <li><a href="https://github.com/axios/axios/commit/085f56861a83e9ac02c140ad9d68dac540dfeeaa"><code>085f568</code></a> fix(fetch): fix content length calculation for FormData payload; (<a href="https://redirect.github.com/axios/axios/issues/6524">#6524</a>)</li> <li><a href="https://github.com/axios/axios/commit/59cd6b0dece4050b190717a7c5cdf77906ce2104"><code>59cd6b0</code></a> chore(release): v1.7.5 (<a href="https://redirect.github.com/axios/axios/issues/6574">#6574</a>)</li> <li><a href="https://github.com/axios/axios/commit/6700a8adac06942205f6a7a21421ecb36c4e0852"><code>6700a8a</code></a> fix(core): add the missed implementation of AxiosError#status property; (<a href="https://redirect.github.com/axios/axios/issues/6573">#6573</a>)</li> <li>Additional commits viewable in <a href="https://github.com/axios/axios/compare/v1.7.2...v1.7.7">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #6554, we're not setting the sender field in sent emails. This is actually required per RFC 822.
Fixes #6554
How to test this patch
Send some emails from @stefanosgeo's systems. I can't reproduce, since gmail doesn't seem to care :D
Your pull request should…
explain why it needs to be merged into the legacy branch, if it is targeting the legacy branch