MH-12946 Fix summary of add-event-dialog#290
Conversation
| }, | ||
| "SUMMARY": { | ||
| "CAPTION": "Summary" | ||
| "CAPTION": "Summary", |
There was a problem hiding this comment.
Bit late for changing the translations innit? I don't think this can go into 5.x as is...
There was a problem hiding this comment.
Otherwise tests look good. My sole complaint is this translation change.
There was a problem hiding this comment.
@KatrinIhler It is indeed true that a proposal was accepted that forbids translation changes into release branches. Can you factor out the translation change and do that in a separate PR against develop? You could just do it without i18n support here - at the end of the day, it is too late to re-translate 5.x anyway...
There was a problem hiding this comment.
You're both right, and I had a feeling you would complain about that. ;) Just wanted to know what you would suggest... I've decided to simply leave out the 'Input'-prefix in the summary completely instead of having it be untranslated here since that's pretty ugly and obvious in my opinion and it's still understandable what these table entries mean without it, and I'm gonna reintroduce it in a separated PR targeted at develop.
Fix the summary of the add-event-dialog by showing the data fields only for the relevent source, fix presentation of end date, show input settings of chosen capture agent in summary and improve their presentation in the source tab.
KatrinIhler
force-pushed
the
t/MH-12946-add-event-summary
branch
from
e06cc83 to
d6e2a0e
Compare
3 participants
Fix the summary of the add-event-dialog. In detail:
Screenshots of source and summary tab each for 'upload', 'schedule single' and 'schedule multiple':
This work is sponsored by SWITCH.