OBPIH-7580 add new root causes to cycle count reporting#5625
Merged
ewaterman merged 1 commit intorelease/0.9.6from Nov 14, 2025
Merged
OBPIH-7580 add new root causes to cycle count reporting#5625ewaterman merged 1 commit intorelease/0.9.6from
ewaterman merged 1 commit intorelease/0.9.6from
Conversation
github-actions
bot
added
type: bug
kchelstowski
approved these changes
Nov 14, 2025
ewaterman
commented
Nov 14, 2025
| ERROR_IN_OUTBOUND: 'Error in outbound', | ||
| BIN_LOCATION_MISSING: 'Bin location missing', | ||
| MISPLACED: 'Misplaced', | ||
| OTHER: 'Other', |
Member
Author
There was a problem hiding this comment.
I had two thoughts while making this change:
- This const is named "reasonCodes" but it only has cycle count reason codes. We should consider renaming it for clarity
- Do we even need this list? The CC resolution flow fetches this list from the backend via API so hopefully we can do the same for reporting. That way we can get properly translated reason codes too.
I'll leave that refactor for after the release though
Collaborator
There was a problem hiding this comment.
I agree we should not have done this like that. We must have missed that during code reviews back in the past. I'm fine with doing it properly past release. Would you mind creating a small ticket for that so that we don't forget about it?
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release/0.9.6 #5625 +/- ##
===============================================
Coverage ? 8.51%
Complexity ? 1127
===============================================
Files ? 712
Lines ? 45640
Branches ? 10913
===============================================
Hits ? 3887
Misses ? 41174
Partials ? 579 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Description of Change
Link to GitHub issue or Jira ticket: https://pihemr.atlassian.net/browse/OBPIH-7580
Description:
📷 Screenshots & Recordings (optional)
https://jam.dev/c/1cee7306-41bc-4dea-a867-6f57ab5d99df