OBPIH-7579 Prevent QOH from being cleared after saving twice in a row#5624
Merged
kchelstowski merged 2 commits intorelease/0.9.6from Nov 14, 2025
Merged
OBPIH-7579 Prevent QOH from being cleared after saving twice in a row#5624kchelstowski merged 2 commits intorelease/0.9.6from
kchelstowski merged 2 commits intorelease/0.9.6from
Conversation
kchelstowski
requested review from
SebastianLib,
alannadolny,
awalkowiak and
ewaterman
github-actions
bot
added
type: bug
alannadolny
reviewed
Nov 14, 2025
| const mapPropertiesOfItemsToBeAdded = (item) => { | ||
| const itemQuantityCounted = item.quantityOnHand | ||
| // The truthiness check is not enough as 0 is a valid value that we want to save | ||
| const itemQuantityCounted = (item.quantityOnHand || item?.quantityOnHand === 0) |
Collaborator
There was a problem hiding this comment.
Don't you need to add a nullsafe operator in the first item.quantityOnHand?
Collaborator
Author
There was a problem hiding this comment.
The item can't be null/undefined, as this method is called as a callback/"transformer" in a .map function
Collaborator
There was a problem hiding this comment.
So the nullsafe that you added is also unnecessary
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release/0.9.6 #5624 +/- ##
===============================================
Coverage ? 8.51%
Complexity ? 1127
===============================================
Files ? 712
Lines ? 45640
Branches ? 10913
===============================================
Hits ? 3887
Misses ? 41174
Partials ? 579 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
alannadolny
approved these changes
Nov 14, 2025
SebastianLib
approved these changes
Nov 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Description of Change
Link to GitHub issue or Jira ticket:
Description:
📷 Screenshots & Recordings (optional)