Skip to content

WIP quantity requested. how to deal with new lines?#5607

Merged
ewaterman merged 3 commits intobug/OBPIH-7184-2from
OBPIH-7184-2-version-experiment
Nov 6, 2025
Merged

WIP quantity requested. how to deal with new lines?#5607
ewaterman merged 3 commits intobug/OBPIH-7184-2from
OBPIH-7184-2-version-experiment

Conversation

@ewaterman
Copy link
Member

Broke this WIP into its own branch for clarity. We're trying to find a way to fix the issue of not being able to set quantity requested to 0 on pull replenishment types and on requests from wards with stocklists

@ewaterman ewaterman self-assigned this Nov 6, 2025
@ewaterman ewaterman added the warn: do not merge Marks a pull request that is not yet ready to be merged label Nov 6, 2025
@github-actions github-actions bot added domain: frontend Changes or discussions relating to the frontend UI domain: backend Changes or discussions relating to the backend server labels Nov 6, 2025
@ewaterman ewaterman changed the title WIP doesn't work for newly added lines WIP quantity requested. how to deal with new lines? Nov 6, 2025
@codecov
Copy link

codecov bot commented Nov 6, 2025

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (bug/OBPIH-7184-2@ce40519). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...ovy/org/pih/warehouse/api/StockMovementItem.groovy 0.00% 3 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                 @@
##             bug/OBPIH-7184-2   #5607   +/-   ##
==================================================
  Coverage                    ?   8.49%           
  Complexity                  ?    1116           
==================================================
  Files                       ?     711           
  Lines                       ?   45594           
  Branches                    ?   10909           
==================================================
  Hits                        ?    3875           
  Misses                      ?   41145           
  Partials                    ?     574           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ewaterman ewaterman merged commit e93d22c into bug/OBPIH-7184-2 Nov 6, 2025
5 checks passed
@ewaterman ewaterman deleted the OBPIH-7184-2-version-experiment branch November 6, 2025 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

domain: backend Changes or discussions relating to the backend server domain: frontend Changes or discussions relating to the frontend UI warn: do not merge Marks a pull request that is not yet ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant