Skip to content

OBPIH-7529 p2. request detail report sorting and subcategory filter#5589

Merged
alannadolny merged 4 commits intodevelopfrom
ft/OBPIH-7529-1
Nov 4, 2025
Merged

OBPIH-7529 p2. request detail report sorting and subcategory filter#5589
alannadolny merged 4 commits intodevelopfrom
ft/OBPIH-7529-1

Conversation

@ewaterman
Copy link
Member

@ewaterman ewaterman commented Oct 31, 2025

✨ Description of Change

Link to GitHub issue or Jira ticket: https://pihemr.atlassian.net/browse/OBPIH-7529

Description: Three changes to the request detail report:

  1. Add ability to filter by product subcategory
  2. Add a default sort order (origin, request number) to the table
  3. Add a default sort order to the API as well so that the CSV download order matches the table in the UI

These ended up being easier than I thought so I could have done them in the original PR but oh well.


📷 Screenshots & Recordings (optional)

Screenshot from 2025-10-31 09-12-25

@ewaterman ewaterman self-assigned this Oct 31, 2025
@github-actions github-actions bot added type: feature A new piece of functionality for the app domain: frontend Changes or discussions relating to the frontend UI domain: backend Changes or discussions relating to the backend server labels Oct 31, 2025
@codecov
Copy link

codecov bot commented Oct 31, 2025

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 8.49%. Comparing base (1bb7314) to head (fbf3b04).
⚠️ Report is 175 commits behind head on develop.

Files with missing lines Patch % Lines
...ih/warehouse/forecasting/ForecastingService.groovy 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             develop   #5589      +/-   ##
============================================
- Coverage       9.12%   8.49%   -0.64%     
+ Complexity      1170    1115      -55     
============================================
  Files            701     711      +10     
  Lines          45281   45580     +299     
  Branches       10851   10906      +55     
============================================
- Hits            4131    3870     -261     
- Misses         40497   41135     +638     
+ Partials         653     575      -78     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@alannadolny alannadolny merged commit 3b2bbe0 into develop Nov 4, 2025
4 of 5 checks passed
@alannadolny alannadolny deleted the ft/OBPIH-7529-1 branch November 4, 2025 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

domain: backend Changes or discussions relating to the backend server domain: frontend Changes or discussions relating to the frontend UI type: feature A new piece of functionality for the app

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants