OBPIH-6160 Restrict Location type creation and editing to superusers#5587
Merged
alannadolny merged 1 commit intodevelopfrom Nov 4, 2025
Merged
OBPIH-6160 Restrict Location type creation and editing to superusers#5587alannadolny merged 1 commit intodevelopfrom
alannadolny merged 1 commit intodevelopfrom
Conversation
github-actions
bot
added
type: feature
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #5587 +/- ##
============================================
- Coverage 9.12% 8.49% -0.63%
+ Complexity 1170 1114 -56
============================================
Files 701 711 +10
Lines 45281 45569 +288
Branches 10851 10902 +51
============================================
- Hits 4131 3872 -259
- Misses 40497 41123 +626
+ Partials 653 574 -79 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| 'transactionEntry' : ['edit', 'delete', 'save', 'update'], | ||
| 'user' : ['impersonate'], | ||
| 'productsConfigurationApi' : ['downloadCategories', 'importCategories'], | ||
| 'locationType' : ['create', 'edit', 'delete'], |
Collaborator
There was a problem hiding this comment.
how about the update, save? I don't remember exactly how those rules work, but I know that update and save are usually different controller actions than create and edit
Collaborator
Author
There was a problem hiding this comment.
I can't find where update and save are used. I blocked only those actions that can be called from the UI to avoid blocking actions that shouldn't be blocked.
Collaborator
There was a problem hiding this comment.
alannadolny
force-pushed
the
ft/OBPIH-6160
branch
from
825e1c7 to
ce40db1
Compare
kchelstowski
approved these changes
Nov 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.