OBPIH-7556 Screen goes blank after adding row with exp date in cycle count in es_mx locale#5584
Merged
alannadolny merged 1 commit intodevelopfrom Oct 31, 2025
Merged
OBPIH-7556 Screen goes blank after adding row with exp date in cycle count in es_mx locale#5584alannadolny merged 1 commit intodevelopfrom
alannadolny merged 1 commit intodevelopfrom
Conversation
github-actions
bot
added
type: bug
SebastianLib
approved these changes
Oct 30, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #5584 +/- ##
============================================
- Coverage 9.12% 8.50% -0.63%
+ Complexity 1170 1112 -58
============================================
Files 701 707 +6
Lines 45281 45448 +167
Branches 10851 10885 +34
============================================
- Hits 4131 3864 -267
- Misses 40497 41010 +513
+ Partials 653 574 -79 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kchelstowski
approved these changes
Oct 30, 2025
| ? moment(new Date(dateToFormat), DateFormat.MMM_DD_YYYY_HH_MM_SS) | ||
| : moment(new Date(dateToFormat), DateFormat.MMM_DD_YYYY); | ||
| // Fallback to default parsing | ||
| return moment(dateToFormat); |
Collaborator
There was a problem hiding this comment.
why isn't new Date() required here anymore? was it redundant before?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.