OBPIH-7346 add more cycle count reason codes#5582
Conversation
github-actions
bot
added
type: feature
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #5582 +/- ##
============================================
- Coverage 9.12% 8.50% -0.62%
+ Complexity 1170 1113 -57
============================================
Files 701 707 +6
Lines 45281 45450 +169
Branches 10851 10886 +35
============================================
- Hits 4131 3867 -264
- Misses 40497 41009 +512
+ Partials 653 574 -79 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| DYNAMIC_CREATION, | ||
| AUTOSAVE, | ||
| ALLOW_OVERPICK, | ||
| CYCLE_COUNT, |
There was a problem hiding this comment.
Adding the code to this list makes it configurable on locations/locationtypes. We don't have another way to add the code but hide it from locations and it feels weird to exclude it from a generic list() of all values in the enum.
We should probably have a boolean field or a listLocationActivityCodes() method but I wanted to keep this PR small so left it as is. We probably do want to support disabling CC on certain locations anyways, not that we have a use for doing so now.
| ] | ||
| } | ||
|
|
||
| static listCycleCountReasonCodes() { |
There was a problem hiding this comment.
if on cycle count we were previously using the listInventoryAdjustmentReasonCodes, shouldn't we just merge the listInventoryAdjustmentReasonCodes with additional activitiy codes here?
Unless you did it intentionally to repeat some of them just to keep it more maintainable and not having to rely on listInventoryAdjustmentReasonCodes in the future?
There was a problem hiding this comment.
yeah I considered doing this but I wanted to avoid the case where in the future we add a reason code to inventory adjustment that we don't want in cycle count. Just because they're the same, doesn't mean they'll stay that way.
But if we assume that a cycle count should always have all the inventory adjustment reason codes, then yes it makes sense to merge them. I can ask Manon
3 participants
✨ Description of Change
Link to GitHub issue or Jira ticket: https://pihemr.atlassian.net/browse/OBPIH-7346
Description: Add support for new reason codes (aka root causes) for cycle count. This required me to add a new activity code.
📷 Screenshots & Recordings (optional)