OBPIH-6993 fix3. filter multiple products when downloading transactio…#5580
Merged
OBPIH-6993 fix3. filter multiple products when downloading transactio…#5580
Conversation
github-actions
bot
added
type: bug
ewaterman
commented
Oct 29, 2025
| selectedProducts.forEach(productId => { | ||
| data.push({ name: "products", value: productId }); | ||
| }); | ||
| } |
Member
Author
There was a problem hiding this comment.
This is what makes it produce products=1&products=2 which is the preferred approach
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #5580 +/- ##
============================================
- Coverage 9.12% 8.50% -0.63%
+ Complexity 1170 1111 -59
============================================
Files 701 707 +6
Lines 45281 45446 +165
Branches 10851 10884 +33
============================================
- Hits 4131 3863 -268
- Misses 40497 41008 +511
+ Partials 653 575 -78 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kchelstowski
approved these changes
Oct 30, 2025
Co-authored-by: Kacper Chełstowski <[email protected]>
alannadolny
approved these changes
Oct 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…n report
✨ Description of Change
Link to GitHub issue or Jira ticket: https://pihemr.atlassian.net/browse/OBPIH-6993
Description: When querying the transaction report, the datatables plugin sends
products=1,2but when downloading the report as CSV it sendsproducts=1&products=2. Grails can auto handle the latter, but the former we needed to handle manually. The bug was caused because I wasn't properly handling the latter scenario. I modified the datatables solution to split the params like the CSV download was doing which let me remove the TODO and fix the bug.