OBPIH-7555 Create UI for Expiration History report#5577
OBPIH-7555 Create UI for Expiration History report#5577alannadolny merged 11 commits intodevelopfrom
Conversation
github-actions
bot
added
type: feature
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5577 +/- ##
============================================
- Coverage 9.12% 8.53% -0.59%
+ Complexity 1170 1125 -45
============================================
Files 701 711 +10
Lines 45281 45581 +300
Branches 10851 10906 +55
============================================
- Hits 4131 3892 -239
- Misses 40497 41110 +613
+ Partials 653 579 -74 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
alannadolny
force-pushed
the
ft/OBPIH-7555
branch
from
81ecb44 to
47eca65
Compare
alannadolny
requested review from
SebastianLib,
awalkowiak,
ewaterman and
kchelstowski
| loading={loading} | ||
| /> | ||
| </div> | ||
| </PageWrapper> |
There was a problem hiding this comment.
I like how clean this component breakdown is 👍
| }, [tableData]); | ||
|
|
||
| const columns = useMemo(() => [ | ||
| columnHelper.accessor('transactionNumber', { |
There was a problem hiding this comment.
I think we should move this to a constants file
| const columns = useMemo(() => [ | ||
| columnHelper.accessor('transactionNumber', { | ||
| header: () => ( | ||
| <TableHeaderCell columnId="transactionNumber"> |
There was a problem hiding this comment.
Do we need this columnId here? We already pass it in accessorKey above
src/js/components/reporting/expirationHistoryReport/ExpirationHistoryReportTable.jsx
Show resolved
Hide resolved
kchelstowski
left a comment
kchelstowski
left a comment
There was a problem hiding this comment.
@SebastianLib I agree with your comments and I don't have any other suggestions from myself. Please take this one and apply your requested changes.
…rt row; add new URL
…ields and enhance filter handling
…ilter handling and data fetching
SebastianLib
force-pushed
the
ft/OBPIH-7555
branch
from
a2feb26 to
78cf08b
Compare
| @mixin | ||
| limit-lines($lines-number) { | ||
| overflow: hidden; | ||
| display: -webkit-box; | ||
| -webkit-line-clamp: $lines-number; | ||
| line-clamp: $lines-number; | ||
| -webkit-box-orient: vertical; | ||
| } | ||
|
|
||
| @for $i from 1 through 10 { | ||
| .limit-lines-#{$i} { | ||
| @include limit-lines($i); | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
I removed this from cycleCount.scss and added it here because we want to use class limit-lines in other components as well, not only in the cycle count.
| defaultMessage: 'Start Date', | ||
| localizeDate: true, | ||
| localizedDateFormat: DateFormat.COMMON, | ||
| dateFormat: DateFormat.DD_MMM_YYYY, |
There was a problem hiding this comment.
The previous implementation had an issue when fetching date parameters from the URL (I assume translating dates). For a moment, we had something like what’s shown in the screenshot and the video:
2025-11-03.13-54-09.mp4
After discussing with the rest of the team, we decided that there is no sense to waste time on this and the best approach is to implement it the same way as in other filters (e.g., cycle count, products list, etc.):
dateFormat: DateFormat.DD_MMM_YYYY
This way we no longer have issues with date translation, but the filter field will display dates only in English.
4 participants
No description provided.