OBPIH-7184 keep 0 qty requisition items#5570
Merged
Conversation
ewaterman
requested review from
SebastianLib,
alannadolny,
awalkowiak and
kchelstowski
github-actions
bot
added
type: feature
Member
Author
|
FYI I haven't had a chance to test this thoroughly yet but it does appear to be working |
ewaterman
changed the title
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5570 +/- ##
============================================
- Coverage 9.12% 8.54% -0.59%
+ Complexity 1170 1116 -54
============================================
Files 701 703 +2
Lines 45281 45348 +67
Branches 10851 10868 +17
============================================
- Hits 4131 3874 -257
- Misses 40497 40896 +399
+ Partials 653 578 -75 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Comment on lines
-1281
to
+1276
| const zeroedLines = _.some(lineItems, (item) => !item.quantityRequested || item.quantityRequested === '0'); | ||
| if (zeroedLines || this.state.isRequestFromWard) { | ||
| if (this.state.isRequestFromWard) { |
Collaborator
There was a problem hiding this comment.
Are you sure we don’t need to do the same thing in Create Outbound? When we use the stocklist, we also have the needed qty 🤔
Member
Author
There was a problem hiding this comment.
confirmed in standup that we only need this change in requisitions
SebastianLib
approved these changes
Oct 27, 2025
SebastianLib
pushed a commit
that referenced
this pull request
Oct 30, 2025
Issues attributed to commits in this pull requestThis pull request was merged and Sentry observed the following issues:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Description of Change
Link to GitHub issue or Jira ticket: https://pihemr.atlassian.net/browse/OBPIH-7184
Description: See ticket for further details but we no longer want to delete rows with Needed Qty == 0 when saving a requisition.
📷 Screenshots & Recordings (optional)
Video showing that saving the requisition while there are rows with Needed Qty == 0 does not show the warning message and allows the rows to be saved.
2025-10-24_11-38-07.mp4