OBPIH-7187 Allow user to remove reason code after deleting revised qty#5566
OBPIH-7187 Allow user to remove reason code after deleting revised qty#5566alannadolny merged 1 commit intodevelopfrom
Conversation
SebastianLib
requested review from
alannadolny,
awalkowiak,
ewaterman and
kchelstowski
github-actions
bot
added
type: feature
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #5566 +/- ##
============================================
- Coverage 9.12% 8.50% -0.62%
+ Complexity 1170 1109 -61
============================================
Files 701 702 +1
Lines 45281 45335 +54
Branches 10851 10867 +16
============================================
- Hits 4131 3856 -275
- Misses 40497 40904 +407
+ Partials 653 575 -78 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| const selectedReasonCode = values?.editPageItems[rowIndex]?.reasonCode; | ||
| return { | ||
| disabled: fieldValue === null || fieldValue === undefined || subfield || isSubstituted, | ||
| disabled: ((fieldValue === null || fieldValue === undefined) && !selectedReasonCode) |
There was a problem hiding this comment.
how does it reflect to "allow to remove reason code after deleting revised qty"? I don't see anything related to the revised quantity added by you here 🤔
There was a problem hiding this comment.
fieldValue here actually represents the revised quantity, since this field uses fieldKey: 'quantityRevised'. We now disable the 'Reason Code' dropdown if there’s nothing in either 'Qty Revised' or 'Reason Code'. You can see how it works now here: https://jam.dev/c/814c44f4-e782-4ac3-90c9-ce327f22233f
3 participants
✨ Description of Change
Link to GitHub issue or Jira ticket:
https://pihemr.atlassian.net/browse/OBPIH-7187
Description:
📷 Screenshots & Recordings (optional)