Skip to content

OBPIH-6993 add product filter to transaction report#5558

Merged
ewaterman merged 5 commits intodevelopfrom
ft/OBPIH-6993-filter-transaction-report-by-product
Oct 21, 2025
Merged

OBPIH-6993 add product filter to transaction report#5558
ewaterman merged 5 commits intodevelopfrom
ft/OBPIH-6993-filter-transaction-report-by-product

Conversation

@ewaterman
Copy link
Member

✨ Description of Change

Link to GitHub issue or Jira ticket: https://pihemr.atlassian.net/browse/OBPIH-6993

Description: Add the ability to filter the transaction report by a list of products.


📷 Screenshots & Recordings (optional)

image

@ewaterman ewaterman self-assigned this Oct 16, 2025
@ewaterman ewaterman added the status: work in progress For issues or pull requests that are in progress but not yet completed label Oct 16, 2025
@github-actions github-actions bot added type: feature A new piece of functionality for the app domain: frontend Changes or discussions relating to the frontend UI domain: backend Changes or discussions relating to the backend server labels Oct 16, 2025
@ewaterman
Copy link
Member Author

I'm still trying to figure this one out. I must be missing something because the products param isn't getting populated properly. No idea why though...

@codecov
Copy link

codecov bot commented Oct 16, 2025

Codecov Report

❌ Patch coverage is 0% with 29 lines in your changes missing coverage. Please review.
✅ Project coverage is 8.47%. Comparing base (1bb7314) to head (17870e1).
⚠️ Report is 152 commits behind head on develop.

Files with missing lines Patch % Lines
...s-app/taglib/org/pih/warehouse/SelectTagLib.groovy 0.00% 21 Missing ⚠️
...ices/org/pih/warehouse/report/ReportService.groovy 0.00% 5 Missing ⚠️
...ontrollers/org/pih/warehouse/JsonController.groovy 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             develop   #5558      +/-   ##
============================================
- Coverage       9.12%   8.47%   -0.65%     
+ Complexity      1170    1120      -50     
============================================
  Files            701     702       +1     
  Lines          45281   45325      +44     
  Branches       10851   10863      +12     
============================================
- Hits            4131    3841     -290     
- Misses         40497   40911     +414     
+ Partials         653     573      -80     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

// we only want this default config to be applied to old selectors in the SelectTagLib (users of the taglib set
// the "select2", "select2withTag", or "ajaxSelect2" classes to invoke specific defaults).
// New flows use
$("select.select2")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self reminder to test that this doesn't break old selectors

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested a couple other pages and it seems to work fine

@ewaterman ewaterman removed the status: work in progress For issues or pull requests that are in progress but not yet completed label Oct 20, 2025
@ewaterman ewaterman merged commit ffc48be into develop Oct 21, 2025
7 checks passed
@ewaterman ewaterman deleted the ft/OBPIH-6993-filter-transaction-report-by-product branch October 21, 2025 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

domain: backend Changes or discussions relating to the backend server domain: frontend Changes or discussions relating to the frontend UI type: feature A new piece of functionality for the app

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants