OBPIH-6887 products cant be deactivated while on a stocklist#5557
Merged
alannadolny merged 2 commits intodevelopfrom Oct 17, 2025
Merged
Conversation
github-actions
bot
added
type: feature
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5557 +/- ##
============================================
- Coverage 9.12% 8.49% -0.63%
+ Complexity 1170 1106 -64
============================================
Files 701 701
Lines 45281 45277 -4
Branches 10851 10850 -1
============================================
- Hits 4131 3847 -284
- Misses 40497 40857 +360
+ Partials 653 573 -80 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
SebastianLib
approved these changes
Oct 16, 2025
Comment on lines
20
to
21
| import org.pih.warehouse.api.Stocklist | ||
| import org.pih.warehouse.api.StocklistItem |
Collaborator
There was a problem hiding this comment.
Do we need the Stocklist and StocklistItem imports? They don’t seem to be used here, but I might be wrong 🤔
alannadolny
approved these changes
Oct 17, 2025
alannadolny
deleted the
ft/OBPIH-6887-product-cant-deactivate-when-on-stocklist
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Description of Change
Link to GitHub issue or Jira ticket: https://pihemr.atlassian.net/browse/OBPIH-6887
Description: Don't allow a product to be deactivated if it is a part of an active stocklist
📷 Screenshots & Recordings (optional)